Merged
Conversation
Member
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 9 files ± 0 9 suites ±0 3h 12m 34s ⏱️ +45s Results for commit ae74a81. ± Comparison against base commit 3fb02e6. ♻️ This comment has been updated with latest results. |
Member
|
Thanks, @Oisin-M! Would you also be able to add tests for the fixes? |
jacobtomlinson
approved these changes
Oct 3, 2025
Member
jacobtomlinson
left a comment
There was a problem hiding this comment.
These look good thanks! The test failures are related to #12076.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dask.nanstdbrings different results withnumpy.nanstd#12068pre-commit run --all-files