Skip to content

Numpy 2.2 updates for cov function with tests#12079

Merged
TomAugspurger merged 9 commits intodask:mainfrom
mmccarty:numpy-2.0-updates-cov
Oct 3, 2025
Merged

Numpy 2.2 updates for cov function with tests#12079
TomAugspurger merged 9 commits intodask:mainfrom
mmccarty:numpy-2.0-updates-cov

Conversation

@mmccarty
Copy link
Copy Markdown
Member

@mmccarty mmccarty commented Sep 19, 2025

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 19, 2025 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

      9 files  ± 0        9 suites  ±0   3h 14m 24s ⏱️ - 1m 9s
 18 072 tests + 8   16 855 ✅ + 8   1 217 💤 ±0  0 ❌ ±0 
161 722 runs  +72  149 605 ✅ +74  12 117 💤  - 2  0 ❌ ±0 

Results for commit c7d5966. ± Comparison against base commit 6da0e73.

♻️ This comment has been updated with latest results.

@mmccarty mmccarty changed the title Numpy 2.0 updates for cov function with tests Numpy 2.2 updates for cov function with tests Sep 30, 2025
@jacobtomlinson jacobtomlinson mentioned this pull request Oct 1, 2025
Merged
3 tasks
@mmccarty
Copy link
Copy Markdown
Member Author

mmccarty commented Oct 2, 2025

@seberg noted the old behavior is actually a long standing bug that was fixed in numpy/numpy#27661 and suggests we xfail the old behavior.

@jacobtomlinson
Copy link
Copy Markdown
Member

jacobtomlinson commented Oct 2, 2025

Given that the upstream failing tests are known issues (#12076) we might be in a good place to merge this. @TomAugspurger could I ask you to take a quick look at the upstream issues and confirm they aren't related to this PR?

@mmccarty mmccarty marked this pull request as ready for review October 2, 2025 15:14
TomAugspurger
TomAugspurger reviewed Oct 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test question, and one implementation question.

TomAugspurger
TomAugspurger approved these changes Oct 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmccarty!

@TomAugspurger TomAugspurger merged commit a0677f7 into dask:main Oct 3, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dask.corrcoef brings different results with numpy.corrcoef

3 participants

@mmccarty @jacobtomlinson @TomAugspurger