Remove redundant normalize_token variants#10884
Merged
Conversation
9febbaf to
4dff916
Compare
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 3h 24m 5s ⏱️ + 7m 47s Results for commit d2208b5. ± Comparison against base commit 07099e5. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.This pull request removes 1 skipped test and adds 2 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
b0a9ef5 to
9df700d
Compare
c70308c to
0cad4d1
Compare
0cad4d1 to
d48e75c
Compare
0cd8fa7 to
04fca10
Compare
crusaderky
added a commit
to crusaderky/dask
that referenced
this pull request
Feb 9, 2024
04fca10 to
45c0693
Compare
45c0693 to
d2208b5
Compare
Collaborator
|
Just double checking: Should we run performance tests for this? |
Collaborator
Author
Already did. No noticeable regression in the end-to-end coiled/benchmarks, and 50~150ms slowdown overall in the TCPH optimizer runtime (most of it caused by #10883, I expect). |
phofl
approved these changes
Feb 14, 2024
Collaborator
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we use pickle to tokenize unknown objects, we can remove a lot of special cases.
Note 1: performance for numpy tokenization is ensured by using pickle5 buffers in
_normalize_pickle.Note 2: I tried removing all special-case handling for pandas, but it broke gpuci. I did not spend time to investigate. Probably a worthy exercise to do at some point later.