Make dask.compatibility private#10114
Merged
jrbourbeau merged 3 commits intodask:mainfrom Mar 27, 2023
Merged
Conversation
jacobtomlinson
commented
Mar 24, 2023
jrbourbeau
reviewed
Mar 24, 2023
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @jacobtomlinson. Will take a closer look later today. Marking as DNM for now to signal this should go in after the release today
dask.compatibility private
jrbourbeau
approved these changes
Mar 27, 2023
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Looks great, thanks @jacobtomlinson!
I opened up #10119 to discuss this topic more broadly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref #10113 (review)
In
dask-kuberneteswe were usingdask.compatibility.entry_pointswhich were recently removed (#10070) and restored again (#10113). @jrbourbeau mentioned thatdask.compatibilityis not intended to be used outside ofdaskso opening this PR to rename it todask._compatibilitywith a fallback shim and deprecation warning.Side note: This could probably be done for a bunch of code throughout
daskanddistributedto reduce maintenance burden and avoid future breakages. If other folks think this would be helpful I'd be happy to help with this effort.