Restore Entrypoints compatibility#10113
Conversation
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
|
Thanks for the review @graingert |
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @jacobtomlinson @graingert. This looks reasonable to me.
For reference, dask.compatibility is intended to be private so I wouldn't use anything in this module in other projects. Though I acknowledge we're not doing a great job of signaling that through use of leading underscores. I'll open an issue for this later
|
Will merge once CI is finished |
Fair enough. I think we've historically not been great at making a distinction between public/private APIs throughout the Dask projects and this is biting us in a few places at the moment. Renaming to |
pre-commit run --all-filesRestored the test that was removed in #10070 and then imported
importlib_metadata.entry_pointto replace the old implementation.I added an extra commit that adds a deprecation warning so that this can be removed again in the future. But we can pop that commit off if we just want to leave it as it is.