Skip to content

Use declarative setuptools#10102

Merged
jrbourbeau merged 15 commits intodask:mainfrom
graingert:use-declarative-config
Mar 30, 2023
Merged

Use declarative setuptools#10102
jrbourbeau merged 15 commits intodask:mainfrom
graingert:use-declarative-config

Conversation

@graingert
Copy link
Copy Markdown
Member

@graingert graingert commented Mar 22, 2023 •
edited
Loading

like #10055 but keeps setuptools and versioneer for now, maybe dask and distributed can move to hatchling/hatch-vcs in the future

@graingert graingert changed the title format setup.py for setup-py-upgrade use declarative setuptools Mar 22, 2023
@graingert graingert force-pushed the use-declarative-config branch 3 times, most recently from 9871b51 to 0804910 Compare March 22, 2023 11:09
@graingert graingert force-pushed the use-declarative-config branch from 0804910 to be691f0 Compare March 22, 2023 15:30
@graingert graingert marked this pull request as ready for review March 22, 2023 17:14
@graingert graingert requested a review from jrbourbeau March 22, 2023 17:14
@jakirkham jakirkham self-requested a review March 27, 2023 18:23
jrbourbeau
jrbourbeau reviewed Mar 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @graingert! Overall this looks great, thanks for handling all of this. I left a couple of small suggestions and a question. It also looks like there's a merge conflict

@jakirkham would you mind taking a quick look at this if you have a moment? Should be similar to the corresponding PR over in distributed that you've reviewed

graingert and others added 6 commits March 28, 2023 16:29
@github-actions github-actions bot added the documentation Improve or add to documentation label Mar 29, 2023
@graingert graingert closed this Mar 29, 2023
@graingert graingert reopened this Mar 29, 2023
jakirkham
jakirkham reviewed Mar 29, 2023
View reviewed changes
douglasdavis
douglasdavis reviewed Mar 29, 2023
View reviewed changes
@douglasdavis douglasdavis mentioned this pull request Mar 29, 2023
Closed
3 tasks
@jakirkham jakirkham requested a review from jrbourbeau March 29, 2023 19:43
@jakirkham jakirkham mentioned this pull request Mar 30, 2023
Closed
3 tasks
@jakirkham
Copy link
Copy Markdown
Member

jakirkham commented Mar 30, 2023

Any more thoughts on this one?

@jrbourbeau jrbourbeau changed the title use declarative setuptools Use declarative setuptools Mar 30, 2023
jrbourbeau
jrbourbeau approved these changes Mar 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @graingert for all your work here -- and @jakirkham @douglasdavis for the reviews

@jrbourbeau jrbourbeau merged commit 1a18859 into dask:main Mar 30, 2023
@graingert graingert deleted the use-declarative-config branch March 30, 2023 16:01
@jakirkham
Copy link
Copy Markdown
Member

jakirkham commented Mar 30, 2023

Thanks James! 🙏

@douglasdavis douglasdavis mentioned this pull request Apr 5, 2023
Open
@jrbourbeau jrbourbeau mentioned this pull request Apr 14, 2023
Merged
5 tasks
@BerndDoser BerndDoser mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakirkham jakirkham jakirkham left review comments

@douglasdavis douglasdavis douglasdavis left review comments

@jrbourbeau jrbourbeau jrbourbeau approved these changes

Assignees

No one assigned

Labels

documentation Improve or add to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move from setup.py to pyproject.toml

4 participants

@graingert @jakirkham @douglasdavis @jrbourbeau