Use pyproject.toml over setup.{py,cfg}#10055
Closed
douglasdavis wants to merge 4 commits intodask:mainfrom
Closed
Conversation
Member
Author
|
First trip up exposed by CI: looks like the coverage configuration isn't translated properly from |
jrbourbeau
reviewed
Mar 13, 2023
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks for handling this @douglasdavis! I've not taken a close look (yet), but did want to point you to the corresponding PR on the distributed side dask/distributed#7629. It'd be good to take the same approach both in dask/dask and dask/distributed
Member
Author
|
Closing since #10102 is pushing forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.pytopyproject.toml#10032pre-commit run --all-filesThis is a stab at transitioning Dask to use
pyproject.toml. Everything that could be pushed intopyproject.tomlhas been put there. This PR uses the PEP621 compatible hatchling build backend.Files removed
/setup.py(unnecessary)/setup.cfg(unncessary, all tool configuration except flake8 moved to pyproject)/.coveragerc(moved to a table in pyproject)/versioneer.py(use hatch-vcs in pyproject)/dask/_version.py(now auto generated by hatch-vcs)Files added
/pyproject.toml/.flake8(must be added because flake8 doesn't supportpyproject.tomlusageThe version is autogenerated by
hatch-vcs; a new_version.pyis created at installation time (or sdist/wheel building time), so we need to adddask/_version.pyto.gitignore.I reread the contributing docs to see if anything would need to be updated, and it was pretty satisfying to see that I don't think anything needs to be changed. Everything that is documented relies on just
piporpytest, and this PR doesn't change the way either need to be used.