Skip to content

Commit fa7a44c

Browse files
committed
Update test_ufunc_meta
upstream CI failure at https://github.com/dask/dask/actions/runs/19578257113/job/56069330863#step:6:37016 I missed these in #12165. And we can improve the skip / xfail slightly, since it's only the final assertion that fails.
1 parent d420d62 commit fa7a44c

1 file changed

Lines changed: 9 additions & 13 deletions

File tree

dask/array/tests/test_ufunc.py

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,7 @@
2525
@pytest.mark.parametrize(
2626
"name",
2727
[
28-
pytest.param(
29-
"log",
30-
marks=[
31-
pytest.mark.xfail(
32-
condition=NUMPY_GE_240,
33-
reason="https://github.com/numpy/numpy/issues/30095",
34-
)
35-
],
36-
),
28+
"log",
3729
"modf",
3830
"frexp",
3931
],
@@ -46,10 +38,14 @@ def test_ufunc_meta(name):
4638
assert ufunc.__name__ == name
4739
assert disclaimer in ufunc.__doc__
4840

49-
assert (
50-
ufunc.__doc__.replace(disclaimer, "").replace(skip_test, "")
51-
== getattr(np, name).__doc__
52-
)
41+
if not NUMPY_GE_240:
42+
# https://github.com/numpy/numpy/issues/30095
43+
# ufunc inspection doesn't provide argument names, which
44+
# breaks our docstring rewriting
45+
assert (
46+
ufunc.__doc__.replace(disclaimer, "").replace(skip_test, "")
47+
== getattr(np, name).__doc__
48+
)
5349

5450

5551
def test_ufunc():

0 commit comments

Comments
 (0)