chore: drop deprecated RPC instantsendtoaddress
#6686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
WalkthroughThe changes remove the deprecated ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
doc/release-notes-6686.md (1)
4-4: Use past-tense phrasing
Consider changing “is now removed” to “has been removed” to align with the conventional past-tense style in release notes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
doc/release-notes-6686.md(1 hunks)src/wallet/rpcwallet.cpp(0 hunks)
💤 Files with no reviewable changes (1)
- src/wallet/rpcwallet.cpp
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: linux64_multiprocess-test / Test source
- GitHub Check: linux64_tsan-test / Test source
🔇 Additional comments (1)
doc/release-notes-6686.md (1)
1-3: Header formatting is consistent
The section title and underline match the repository’s release‐note style.
UdjinM6
reviewed
May 26, 2025
PastaPastaPasta
added a commit
that referenced
this pull request
May 26, 2025
…pcwallet) 730ef82 merge bitcoin#23667: Split up rpcwallet (Kittywhiskers Van Gogh) bf18e7a Remove unused imports from rpc/wallet and reorder RPCs (Kittywhiskers Van Gogh) d17884f MOVEONLY: Move rpcwallet to rpc/wallet (Kittywhiskers Van Gogh) 1290783 MOVEONLY: Move spending RPCs to spend.cpp (Kittywhiskers Van Gogh) 36107c7 MOVEONLY: Move balance and utxo RPCs to coins.cpp (Kittywhiskers Van Gogh) 0aac1b3 MOVEONLY: Move address related functions from rpcwallet to addresses.cpp (Kittywhiskers Van Gogh) 6dcf2a2 MOVEONLY: Move transaction related wallet RPCs to transactions.cpp (Kittywhiskers Van Gogh) c080211 merge bitcoin#23647: Move wallet backup and encryption RPCs out of rpcwallet (Kittywhiskers Van Gogh) Pull request description: ## Additional Information * Depends on #6686 * [bitcoin#23667](bitcoin#23667) was merged upstream in v0.23. As of this writing, the backport backlog for v0.23 is at ~90% completion. While this refactor is disruptive, delaying it makes any backport after v0.23 at best annoying and at worst, causing history inconsistency, which may cause conflicts. * While the commits for [bitcoin#23647](bitcoin#23647) have been squashed down, due to the diff size, [bitcoin#23667](bitcoin#23667) is available commit-by-commit. Both can be validated as primarily move-only with `git log -p -n1 --color-moved=dimmed_zebra`. * In [bitcoin#23647](bitcoin#23647), `LoadWalletHelper` was moved to `wallet/rpc/util.cpp` but [bitcoin#23721](bitcoin#23721) (included in [dash#6137](#6137)) replaced it with `HandleWalletError`. Due to this OOO backport, changes in [bitcoin#23647](bitcoin#23647) adopts portions of [bitcoin#23721](bitcoin#23721) for correctness and consistency. * [bitcoin#23667](bitcoin#23667) does not move `walletdisplayaddress` as it is not implemented yet on account of relying on external signer support (which is the same reason why [bitcoin#23172](bitcoin#23172) hasn't been backported per the spreadsheet and `FundTxDoc` wasn't moved in this PR as it isn't backported yet). This needs to be kept in mind when backporting [bitcoin#23172](bitcoin#23172) and [bitcoin#21467](bitcoin#21467) (and its predecessors). ## Breaking Changes None expected. All changes are move-only. ## Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 730ef82 PastaPastaPasta: utACK 730ef82 Tree-SHA512: 445d3e42ea73b745d71b4cbfedd891359701aec25542a9d58f514e22dc059e665659fdd428ea71204996163a90c33b0621f4bc415691f1b42e7a2f558f035642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Information
instantsendtoaddresswas deprecated in dash#3020, which was included in Dash Core v0.15.Breaking Changes
Deprecated RPC will no longer be available.
Checklist