Merge bitcoin#16278: tests: Remove unused includes #4528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please rebase. |
c516334 to
e27c1a3
Compare
8e8588a to
bfe027d
Compare
|
This pull request has conflicts, please rebase. |
bfe027d to
b956167
Compare
b956167 to
e293ab7
Compare
e293ab7 to
5dcb498
Compare
ad50aa6 to
7cad30a
Compare
|
This pull request has conflicts, please rebase. |
7cad30a to
d35e91c
Compare
d35e91c to
e0db284
Compare
|
This pull request has conflicts, please rebase. |
2caa6e0 to
3de39b5
Compare
1aac6bf to
51ccd6a
Compare
99fe935 to
3f839b0
Compare
9a84169 tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (practicalswift) Pull request description: Reduce compilation time and unneccessary recompiles by removing unused includes in tests. A subset of bitcoin#16273 ("refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes") as requested by MarcoFalke in bitcoin#16273 (comment). ACKs for top commit: Sjors: ACK 9a84169 on macOS 10.14.5 (I rebased on bitcoin#16289) Tree-SHA512: bcb6ecffef689a9839bee1a5cb93abe83db1f30819a54226c5630fee456b5a5d187507d06861454adfda939c3556a975113f97662e415cb47fa0327ea4fd09fb
3f839b0 to
89b2ecc
Compare
Author
UdjinM6
approved these changes
Nov 30, 2021
UdjinM6
left a comment
There was a problem hiding this comment.
re-utACK
(github is doing weird things here again)
PastaPastaPasta
approved these changes
Nov 30, 2021
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 10, 2023
9a84169 tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (practicalswift) Pull request description: Reduce compilation time and unneccessary recompiles by removing unused includes in tests. A subset of bitcoin#16273 ("refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes") as requested by MarcoFalke in bitcoin#16273 (comment). ACKs for top commit: Sjors: ACK 9a84169 on macOS 10.14.5 (I rebased on bitcoin#16289) Tree-SHA512: bcb6ecffef689a9839bee1a5cb93abe83db1f30819a54226c5630fee456b5a5d187507d06861454adfda939c3556a975113f97662e415cb47fa0327ea4fd09fb Co-authored-by: MarcoFalke <falke.marco@gmail.com>
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
9a84169 tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (practicalswift) Pull request description: Reduce compilation time and unneccessary recompiles by removing unused includes in tests. A subset of bitcoin#16273 ("refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes") as requested by MarcoFalke in bitcoin#16273 (comment). ACKs for top commit: Sjors: ACK 9a84169 on macOS 10.14.5 (I rebased on bitcoin#16289) Tree-SHA512: bcb6ecffef689a9839bee1a5cb93abe83db1f30819a54226c5630fee456b5a5d187507d06861454adfda939c3556a975113f97662e415cb47fa0327ea4fd09fb Co-authored-by: MarcoFalke <falke.marco@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have below two files to change
wallet/test/ismine_tests.cpp
src/test/key_properties.cpp
removed unused includes from all other files as done by upstream.