governance: Implement reduced governance fee #4241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We passed the governance vote https://www.dashcentral.org/p/reduce-the-proposal-fee-to-one-dash happy to help with testing and will talk to Phez about documentation updates proposal generator code seems not impacted by this change, but will test as well. |
UdjinM6
requested changes
Jul 28, 2021
UdjinM6
requested changes
Jul 29, 2021
UdjinM6
left a comment
There was a problem hiding this comment.
Well, at least CI is happy now :)
Few suggestions re timestamps.
Member
Author
|
Hmm, I think I would propose that we postpone the merging of this until hopefully after we implement the new enhanced hard forking. |
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 21, 2021
d003110 Remove unused guard (Hennadii Stepanov) Pull request description: `BITCOIN_QT_TEST` is no longer used since switching to autotools build system. Some historical refs: - dashpay#807 - dashpay#4241 ACKs for top commit: practicalswift: utACK d003110 promag: ACK d003110. jonasschnelli: Verified ACK d003110 Tree-SHA512: 1242ef7927d2dbd2e47cdb50de6ebb20e4ac427a66a37b4d4de8ca1b50581d34f818cb576fc9fdfb3e7dd7259d11812e3807da33b3357850d67548b837d5549b
Signed-off-by: pasta <pasta@dashboost.org>
f6cbbd3 to
140412c
Compare
thephez
reviewed
Oct 25, 2021
src/chainparams.cpp
Outdated
|
|
||
| // Deployment of decreased proposal fee | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_GOV_FEE].bit = 7; | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_GOV_FEE].nStartTime = calculate_timestamp(2021, MONTH::DEC, 1); |
Collaborator
There was a problem hiding this comment.
Great, now I'm going to have to convert this to a unix timestamp so I can make some sense out of it. 
You kids with your fancy ways of tracking time 🙄
140412c to
a71541a
Compare
Member
Author
|
Dropped, please review |
Member
Author
|
If only we had some compile time function to calculate timestamps for us... Hmm, maybe an idea for another PR. changes applied |
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
* Implement hf for reduced governance fee Signed-off-by: pasta <pasta@dashboost.org> * update VersionBitsDeploymentInfo * Adjust activation times for gov fee hard fork * Use raw timestamps * Adjust timestamps Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 7, 2023
* Implement hf for reduced governance fee Signed-off-by: pasta <pasta@dashboost.org> * update VersionBitsDeploymentInfo * Adjust activation times for gov fee hard fork * Use raw timestamps * Adjust timestamps Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 11, 2023
d003110 Remove unused guard (Hennadii Stepanov) Pull request description: `BITCOIN_QT_TEST` is no longer used since switching to autotools build system. Some historical refs: - dashpay#807 - dashpay#4241 ACKs for top commit: practicalswift: utACK d003110 promag: ACK d003110. jonasschnelli: Verified ACK d003110 Tree-SHA512: 1242ef7927d2dbd2e47cdb50de6ebb20e4ac427a66a37b4d4de8ca1b50581d34f818cb576fc9fdfb3e7dd7259d11812e3807da33b3357850d67548b837d5549b
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
* Implement hf for reduced governance fee Signed-off-by: pasta <pasta@dashboost.org> * update VersionBitsDeploymentInfo * Adjust activation times for gov fee hard fork * Use raw timestamps * Adjust timestamps Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
d003110 Remove unused guard (Hennadii Stepanov) Pull request description: `BITCOIN_QT_TEST` is no longer used since switching to autotools build system. Some historical refs: - dashpay#807 - dashpay#4241 ACKs for top commit: practicalswift: utACK d003110 promag: ACK d003110. jonasschnelli: Verified ACK d003110 Tree-SHA512: 1242ef7927d2dbd2e47cdb50de6ebb20e4ac427a66a37b4d4de8ca1b50581d34f818cb576fc9fdfb3e7dd7259d11812e3807da33b3357850d67548b837d5549b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by https://www.dashcentral.org/p/reduce-the-proposal-fee-to-one-dash
TODO: