Only load valid themes, fallback to "Light" theme otherwise #3285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarley
reviewed
Jan 13, 2020
nmarley
previously approved these changes
Jan 14, 2020
There was a problem hiding this comment.
utACK
Slight refactor if you wanna take it : nmarley@0f5298d
Author
|
@nmarley Cherry-picked, thanks! |
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 17, 2020
…3285) * Only load valid themes, fallback to "light" otherwise * Refactor PR3285 a bit * fix Co-authored-by: Nathan Marley <nathan.marley@gmail.com>
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
…3285) * Only load valid themes, fallback to "light" otherwise * Refactor PR3285 a bit * fix Co-authored-by: Nathan Marley <nathan.marley@gmail.com> Signed-off-by: cevap <dev@i2pmail.org>
cryptolinux
pushed a commit
to cryptolinux/ion
that referenced
this pull request
Feb 6, 2021
…3285) * Only load valid themes, fallback to "light" otherwise * Refactor PR3285 a bit * fix Co-authored-by: Nathan Marley <nathan.marley@gmail.com> Signed-off-by: cevap <dev@i2pmail.org>
ckti
pushed a commit
to ckti-gitian-ion/ion
that referenced
this pull request
Mar 29, 2021
…3285) * Only load valid themes, fallback to "light" otherwise * Refactor PR3285 a bit * fix Co-authored-by: Nathan Marley <nathan.marley@gmail.com> Signed-off-by: cevap <dev@i2pmail.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help to avoid issues for users still using old themes we removed in #3141 - without this patch they would see some ugly non-styled version the first time they run v0.15 and would have to pick the theme manually.