Do not send excessive messages in governance sync #2124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarley
reviewed
Jun 18, 2018
nmarley
suggested changes
Jun 18, 2018
nmarley
left a comment
There was a problem hiding this comment.
Probably should fix the log message before merging this (commented inline)
000e8c3 to
71916e8
Compare
Author
|
I checked the code once again and I'm still not 100% sure if this PR breaks smth or not. Postponing it till 12.4, needs more testing IMO. |
71916e8 to
72b639c
Compare
72b639c to
06ed62c
Compare
Author
|
Reviving this. Rebased and slightly tested by connecting one patched node with no data directly to another patched one, seems to be working as expected. |
No need to send gobject inv for a single gobject, the other node already knows it, so send votes only. Also, no need to send "fake" stats like "0 votes" when syncing gobjects and "1 object" when syncing votes. Rename functions accordingly.
06ed62c to
0893567
Compare
thephez
added a commit
to thephez/dash-docs
that referenced
this pull request
Apr 16, 2019
- Related to dashpay/dash#2124
thephez
added a commit
to dash-docs/dash-docs
that referenced
this pull request
Apr 17, 2019
* Guide - PrivateSend updates - Variable paticipant count - Link updates * Guide - MN sync reorg - Move all content regarding old mn sync system to a subsection * Guide - Governance sync update - Related to dashpay/dash#2124 * Content - Remove governance watchdog references - Related to dashpay/dash#2816 * Content - Governance sync update * Content - Update Dash Core version and protocol number * Formatting fix * Content - Disclaimer and roadmap link * Content - Update Sentinel info to indicate deprecation of sentinelping * Formatting fix
thephez
added a commit
to thephez/dash-docs
that referenced
this pull request
May 17, 2019
* Guide - PrivateSend updates - Variable paticipant count - Link updates * Guide - MN sync reorg - Move all content regarding old mn sync system to a subsection * Guide - Governance sync update - Related to dashpay/dash#2124 * Content - Remove governance watchdog references - Related to dashpay/dash#2816 * Content - Governance sync update * Content - Update Dash Core version and protocol number * Formatting fix * Content - Disclaimer and roadmap link * Content - Update Sentinel info to indicate deprecation of sentinelping * Formatting fix
thephez
added a commit
to dash-docs/dash-docs
that referenced
this pull request
May 17, 2019
* Guide - PrivateSend updates - Variable paticipant count - Link updates * Guide - MN sync reorg - Move all content regarding old mn sync system to a subsection * Guide - Governance sync update - Related to dashpay/dash#2124 * Content - Remove governance watchdog references - Related to dashpay/dash#2816 * Content - Governance sync update * Content - Update Dash Core version and protocol number * Formatting fix * Content - Disclaimer and roadmap link * Content - Update Sentinel info to indicate deprecation of sentinelping * Formatting fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to send gobject inv for a single gobject, the other node already knows it, so send votes only. Also, no need to send "fake" stats like "0 votes" when syncing gobjects and "1 object" when syncing votes. And finally, rename functions accordingly.
EDIT:
PS. Haven't assigned milestone for now - should be safe to merge in 12.3 IMO, but this PR changes the actual behaviour while (strictly saying) it doesn't fix a critical bug or smth, just removes some excessive/redundant parts, so I'm open for other opinions/arguments.