[code_builder] Set `external` and `static` in correct order by nikeokoronkwo · Pull Request #2120 · dart-lang/tools

nikeokoronkwo · 2025-07-02T13:03:31Z

This PR fixes the order of the external and static keywords in fields to follow correct Dart language structure.
Fields in code_builder should now render as external static rather than static external when both are true.

Contribution guidelines

- [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

github-actions · 2025-07-02T15:11:08Z

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:bazel_worker	1.1.3	already published at pub.dev
package:benchmark_harness	2.4.0-wip	WIP (no publish necessary)
package:boolean_selector	2.1.2	already published at pub.dev
package:browser_launcher	1.1.3	already published at pub.dev
package:cli_config	0.2.1-wip	WIP (no publish necessary)
package:cli_util	0.4.2	already published at pub.dev
package:clock	1.1.3-wip	WIP (no publish necessary)
package:code_builder	4.10.2-wip	WIP (no publish necessary)
package:coverage	1.14.1	already published at pub.dev
package:csslib	1.0.2	already published at pub.dev
package:extension_discovery	2.1.0	already published at pub.dev
package:file	7.0.2-wip	WIP (no publish necessary)
package:file_testing	3.1.0-wip	WIP (no publish necessary)
package:glob	2.1.3	already published at pub.dev
package:graphs	2.3.3-wip	WIP (no publish necessary)
package:html	0.15.6	already published at pub.dev
package:io	1.1.0-wip	WIP (no publish necessary)
package:json_rpc_2	4.0.0	already published at pub.dev
package:markdown	7.3.1-wip	WIP (no publish necessary)
package:mime	2.0.0	already published at pub.dev
package:oauth2	2.0.4-wip	WIP (no publish necessary)
package:package_config	2.3.0-wip	WIP (no publish necessary)
package:pool	1.5.2-wip	WIP (no publish necessary)
package:process	5.0.4	already published at pub.dev
package:pub_semver	2.2.0	already published at pub.dev
package:pubspec_parse	1.5.0	already published at pub.dev
package:source_map_stack_trace	2.1.3-wip	WIP (no publish necessary)
package:source_maps	0.10.14-wip	WIP (no publish necessary)
package:source_span	1.10.1	already published at pub.dev
package:sse	4.1.8	already published at pub.dev
package:stack_trace	1.12.1	already published at pub.dev
package:stream_channel	2.1.4	already published at pub.dev
package:stream_transform	2.1.2-wip	WIP (no publish necessary)
package:string_scanner	1.4.1	already published at pub.dev
package:term_glyph	1.2.3-wip	WIP (no publish necessary)
package:test_reflective_loader	0.3.0	ready to publish	`test_reflective_loader-v0.3.0`
package:timing	1.0.2	already published at pub.dev
package:unified_analytics	8.0.3	ready to publish	`unified_analytics-v8.0.3`
package:watcher	1.1.2	already published at pub.dev
package:yaml	3.1.3	already published at pub.dev
package:yaml_edit	2.2.2	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

mosuem · 2025-07-02T15:13:19Z

LGTM with the failing checks addressed!

github-actions · 2025-07-02T15:14:02Z

PR Health

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

File	Coverage
pkgs/code_builder/lib/src/emitter.dart	💚 97 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks

⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols
code_builder	SpecVisitor ClosureExpression LiteralSetExpression LiteralMapExpression LiteralRecordExpression

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/coverage/lib/src/coverage_options.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/html/test/trie_test.dart
pkgs/html/tool/generate_trie.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

nikeokoronkwo · 2025-07-02T15:55:15Z

LGTM with the failing checks addressed!

I do not know if any work is going on concerning a new version, or if I'm in the position to make such change (as it denotes in the above bot comment).
If possible, then I can update the versions and changelog respectively

kevmoo · 2025-07-02T21:48:03Z

Please update the changelog, too!

srujzs · 2025-07-02T21:53:01Z

@mosuem Is this a breaking change/can we ignore the warning? It seems like any code that could have been generated before would have been invalid anyways.

mosuem · 2025-07-04T06:35:52Z

@mosuem Is this a breaking change/can we ignore the warning? It seems like any code that could have been generated before would have been invalid anyways.

The breaking change check seems to not like the last published version, and shows a lot of breaking changes from InvalidType to some new type. I disabled it on this PR.

mosuem · 2025-07-17T07:33:42Z

Thanks a lot!

Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/61ba1ea..40607dc): 40607dc 2025-07-21 Jacob MacDonald rename ElicitationHandler.reject to ElicitationHandler.decline (dart-lang/ai#240) ec6efa4 2025-07-21 Kostia Sokolovskyi Fix ping request handling from non-dart clients. (dart-lang/ai#239) 00889b4 2025-07-17 Jacob MacDonald release dart_mcp version 0.3.2 (dart-lang/ai#237) 5e93ef4 2025-07-17 Jacob MacDonald Deprecate EnumSchema and JsonType.enumeration (dart-lang/ai#236) 66af21b 2025-07-17 Jacob MacDonald fix the firstMatchOnly and matchRoot schemas to be booleans (dart-lang/ai#235) 141fbe1 2025-07-17 Jacob MacDonald release dart_mcp 0.3.1 (dart-lang/ai#234) ce519e8 2025-07-17 Jacob MacDonald Add flutter driver tool (dart-lang/ai#223) 3bf650e 2025-07-16 Jacob MacDonald add completions support to the prompts example (dart-lang/ai#233) aed93b4 2025-07-16 Jacob MacDonald Deprecate the WithElicitationhandler interface (dart-lang/ai#231) 01cf3d4 2025-07-16 Jacob MacDonald Require dart_mcp version 0.3.1 (dart-lang/ai#232) 5c28640 2025-07-16 Jacob MacDonald add a sampling example (dart-lang/ai#230) df0c4f1 2025-07-16 Jacob MacDonald add elicitation example, fix some issues with the elicitation APIs (dart-lang/ai#229) http (https://github.com/dart-lang/http/compare/2d9681d..4a90d16): 4a90d16 2025-07-21 Alex Li [cronet_http] Update Cronet dependencies version (dart-lang/http#1796) 5c06c6c 2025-07-18 Brian Quinlan Prepare to release cronet 1.4.0 (dart-lang/http#1794) 8c49ef5 2025-07-18 Hossein Yousefi [cronet_http] Upgrade jni and jnigen to 0.14.2 (dart-lang/http#1793) ca07b4c 2025-07-17 Brian Quinlan Add request cancellation to cupertino_http (dart-lang/http#1779) 984cc43 2025-07-15 Brian Quinlan Fix a bug where ConnectionException.toString didn't stringify NSError (dart-lang/http#1785) protobuf (https://github.com/dart-lang/protobuf/compare/04bd6ac..4916e6f): 4916e6f 2025-07-21 Ömer Sinan Ağacan CI: Test PRs and commits to all branches, instead of just master (google/protobuf.dart#1029) a9822d8 2025-07-16 Devon Carew prep for publishing protobuf 4.1.1, protoc_plugin 22.5.0 (google/protobuf.dart#1025) 38f1549 2025-07-15 Devon Carew update the generator to emit formatted files (google/protobuf.dart#1020) test (https://github.com/dart-lang/test/compare/2be5ca0..c201cc9): c201cc98 2025-07-21 Nate Bosch Expand Analyzer constraints to allow 8.x (dart-lang/test#2518) tools (https://github.com/dart-lang/tools/compare/a4335eb..2a2a2d6): 2a2a2d61 2025-07-17 Nikechukwu [code_builder] Set `external` and `static` in correct order (dart-lang/tools#2120) web (https://github.com/dart-lang/web/compare/7e0853d..767151e): 767151e 2025-07-21 Nikechukwu [web_generator] Bug Fixes in Entrypoint `gen_interop_bindings.dart` (dart-lang/web#423) 1f80532 2025-07-21 Nikechukwu [interop] Support `typeof` type declarations (dart-lang/web#417) affce52 2025-07-17 Kevin Moore generator: drop build bits. Not used. (dart-lang/web#419) 0a16c09 2025-07-17 Nikechukwu [interop] Support Classes and Interfaces (dart-lang/web#415) Change-Id: I9fbe6d7c15d63b19e45829628e7c5dfb3e87ca6c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/441820 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

…g#2120)

Set external and static in correct order

39954cb

nikeokoronkwo requested a review from a team as a code owner July 2, 2025 13:03

github-actions Bot added the package:code_builder label Jul 2, 2025

nikeokoronkwo mentioned this pull request Jul 2, 2025

[code_builder] external and static in wrong order for fields #2118

Closed

added tests for external, static and late for field spec

e2b74da

lrhn approved these changes Jul 3, 2025

View reviewed changes

updated CHANGELOG

d11a07a

mosuem added the skip-breaking-check label Jul 4, 2025

Merge branch 'main' into code_builder/external-static

1f78a7d

mosuem merged commit 2a2a2d6 into dart-lang:main Jul 17, 2025
14 checks passed

nikeokoronkwo deleted the code_builder/external-static branch July 17, 2025 13:33

Dhruv-Maradiya pushed a commit to Dhruv-Maradiya/tools that referenced this pull request Oct 15, 2025

[code_builder] Set external and static in correct order (dart-lan…

eee7e0d

…g#2120)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[code_builder] Set `external` and `static` in correct order#2120

[code_builder] Set `external` and `static` in correct order#2120
mosuem merged 4 commits into
dart-lang:mainfrom
nikeokoronkwo:code_builder/external-static

nikeokoronkwo commented Jul 2, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 2, 2025

Uh oh!

mosuem commented Jul 2, 2025

Uh oh!

github-actions Bot commented Jul 2, 2025 •

edited

Loading

Uh oh!

nikeokoronkwo commented Jul 2, 2025

Uh oh!

kevmoo commented Jul 2, 2025

Uh oh!

srujzs commented Jul 2, 2025

Uh oh!

mosuem commented Jul 4, 2025

Uh oh!

Uh oh!

mosuem commented Jul 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

nikeokoronkwo commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 2, 2025

Package publishing

Uh oh!

mosuem commented Jul 2, 2025

Uh oh!

github-actions Bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Health

Uh oh!

nikeokoronkwo commented Jul 2, 2025

Uh oh!

kevmoo commented Jul 2, 2025

Uh oh!

srujzs commented Jul 2, 2025

Uh oh!

mosuem commented Jul 4, 2025

Uh oh!

Uh oh!

mosuem commented Jul 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nikeokoronkwo commented Jul 2, 2025 •

edited

Loading

github-actions Bot commented Jul 2, 2025 •

edited

Loading