Skip to content

Drop support for legacy iframe communication#2099

Merged
natebosch merged 2 commits into
masterfrom
legacy-frame-channel
Sep 25, 2023
Merged

Drop support for legacy iframe communication#2099
natebosch merged 2 commits into
masterfrom
legacy-frame-channel

Conversation

@natebosch

@natebosch natebosch commented Sep 21, 2023

Copy link
Copy Markdown
Member

Closes #2065

All known iframe side implementations have been updated to send the
'port' message with an immediately available channel over the map and
the extra window message.

Move some still relevant assert into the implementation for the
current approach.

@natebosch
Drop support for legacy iframe communication
16e52d0 
Closes #2065

All known iframe side implementations have been updated to send the
`'port'` message with an immediately available channel over the map and
the extra window message.

Move some still relevant `assert` into the implementation for the
current approach.
@natebosch natebosch requested a review from jakemac53 September 21, 2023 00:09
jakemac53
jakemac53 approved these changes Sep 21, 2023
View reviewed changes

@jakemac53 jakemac53 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to run into the issue with missing flutter_test dependencies again?

@natebosch

natebosch commented Sep 25, 2023

Copy link
Copy Markdown
Member Author

Are we going to run into the issue with missing flutter_test dependencies again?

We shouldn't. The two sides of this particular dependency are managed by dependencies in the flutter checkout, not the users project.

flutter/flutter#131881 updated flutter_tools to send the 'port' message, and the compiled host.dart.js is used from the flutter repo pub solve.
https://github.com/flutter/flutter/blob/4d8e390c1be6237ab45df9c57b87e50e499056db/packages/flutter_tools/lib/src/test/flutter_web_platform.dart#L156-L157

This would only be a problem if the iframe code could be an old version - but that is controlled by the test platform, not the pub dependency.

@natebosch natebosch merged commit 7ec1bbf into master Sep 25, 2023
@natebosch natebosch deleted the legacy-frame-channel branch September 25, 2023 18:48
natebosch added a commit that referenced this pull request Jan 17, 2025
@natebosch
Drop reference to legacy communication protocol
697fcf7 
Cleanup following #2065

The support for legacy test suite communication was dropped in #2099 but
I missed a change in this comment which still describes the difference.
@natebosch natebosch mentioned this pull request Jan 17, 2025
Merged
natebosch added a commit that referenced this pull request Jan 17, 2025
@natebosch
Drop reference to legacy communication protocol (#2446)
7fc9521 
Cleanup following #2065

The support for legacy test suite communication was dropped in #2099 but
I missed a change in this comment which still describes the difference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simplify the communication between the browser host and iframe

2 participants

@natebosch @jakemac53