Update dependencies across 3 packages#479
Merged
Merged
Conversation
lrhn
reviewed
Aug 5, 2025
| void testGet({required String path, required String result}) => | ||
| test('GET $path', () async { | ||
| final result = await http.get(server.uri.resolve(path)); | ||
| expect(result, equals(result)); |
Member
There was a problem hiding this comment.
That looks tautological. Maybe rename one of the result variables?
Member
Author
There was a problem hiding this comment.
This is just a reformat pass. We should come back later w/ other code changes.
lrhn
reviewed
Aug 5, 2025
| ), | ||
| ) | ||
| .expand((i) => i) | ||
| .toList(); |
Member
There was a problem hiding this comment.
Can be literal:
classes[cls] =
[for (e in elements)
for (var a in _routeType.annotationsOfExact(e))
_Handler(
a.getField('verb')!.toStringValue()!,
a.getField('route')!.toStringValue()!,
e)
];I think it's easier to read.
Member
Author
There was a problem hiding this comment.
Sure, but also this is just a reformat pass. We should come back later w/ other code changes.
devoncarew
approved these changes
Aug 5, 2025
devoncarew
left a comment
Contributor
There was a problem hiding this comment.
two inline edits; lgtm
| * Require Dart `^3.3.0`. | ||
| * Require `shelf: ^1.1.0` | ||
| * Require `test: ^1.25.15` | ||
| * Require `sdk: ^3.5.0`. |
Contributor
There was a problem hiding this comment.
For similarity with other entries:
Suggested change
| * Require `sdk: ^3.5.0`. | |
| * Require Dart `3.5`. |
Member
Author
There was a problem hiding this comment.
LOL! I was trying to explicitly make these more copy-paste so they are always consistent and minimal effort.
Uh...
I guess auto-merge decided for us.
| * Require `build: ^3.0.0` | ||
| * Require `build_config: ^1.1.0` | ||
| * Require `source_gen: ^3.0.0` | ||
| * Require `sdk: ^3.7.0` |
Contributor
There was a problem hiding this comment.
Suggested change
| * Require `sdk: ^3.7.0` | |
| * Require Dart `3.7`. |
copybara-service Bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 7, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/414953e..82b48b5): 82b48b53 2025-08-05 István Soós Update highlight.js download instructions and resources. (dart-lang/dartdoc#4081) ecosystem (https://github.com/dart-lang/ecosystem/compare/2fe3618..4543c38): 4543c38 2025-08-06 Devon Carew address a `Bad state: No element` element exception (dart-lang/ecosystem#321) e14472f 2025-08-06 Devon Carew add a roadmap to our various mono-repos (dart-lang/ecosystem#318) e83479a 2025-08-06 Moritz Fixes to health (dart-lang/ecosystem#363) 552f534 2025-08-06 Moritz Update API tool hash (dart-lang/ecosystem#362) i18n (https://github.com/dart-lang/i18n/compare/c45e050..25cdb1b): 25cdb1b4 2025-08-07 Moritz Reenable mac size checks (dart-lang/i18n#1001) shelf (https://github.com/dart-lang/shelf/compare/082d3ac..2a46b4f): 2a46b4f 2025-08-05 Kevin Moore Update dependencies across 3 packages (dart-lang/shelf#479) test (https://github.com/dart-lang/test/compare/5aef971..9354f23): 9354f239 2025-08-07 Liam Appelbe Add `--coverage-path` and `--branch-coverage` options (dart-lang/test#2517) tools (https://github.com/dart-lang/tools/compare/5e977d6..1b52e89): 1b52e89e 2025-08-06 Moritz Configure Gemini code review (dart-lang/tools#2141) web (https://github.com/dart-lang/web/compare/1d5771b..f3c960f): f3c960f 2025-08-06 Nikechukwu [web_generator] Add support for passing files as globs (dart-lang/web#427) f51cc85 2025-08-06 Nikechukwu [interop] Add Support for Namespaces (dart-lang/web#436) webdev (https://github.com/dart-lang/webdev/compare/7ff2d07..94c172c): 94c172cc 2025-08-05 Nicholas Shahan Wait for any remaining output in e2e_test.dart (dart-lang/webdev#2663) Change-Id: Ie18635903f7379bc27e7ae23b916e10e4bdcef94 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444360 Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
copybara-service Bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 7, 2025
… webdev" This reverts commit 00240e8. Reason for revert: failures on HHH Original change's description: > [deps] rev dartdoc, ecosystem, i18n, shelf, test, tools, web, webdev > > Revisions updated by `dart tools/rev_sdk_deps.dart`. > > dartdoc (https://github.com/dart-lang/dartdoc/compare/414953e..82b48b5): > 82b48b53 2025-08-05 István Soós Update highlight.js download instructions and resources. (dart-lang/dartdoc#4081) > > ecosystem (https://github.com/dart-lang/ecosystem/compare/2fe3618..4543c38): > 4543c38 2025-08-06 Devon Carew address a `Bad state: No element` element exception (dart-lang/ecosystem#321) > e14472f 2025-08-06 Devon Carew add a roadmap to our various mono-repos (dart-lang/ecosystem#318) > e83479a 2025-08-06 Moritz Fixes to health (dart-lang/ecosystem#363) > 552f534 2025-08-06 Moritz Update API tool hash (dart-lang/ecosystem#362) > > i18n (https://github.com/dart-lang/i18n/compare/c45e050..25cdb1b): > 25cdb1b4 2025-08-07 Moritz Reenable mac size checks (dart-lang/i18n#1001) > > shelf (https://github.com/dart-lang/shelf/compare/082d3ac..2a46b4f): > 2a46b4f 2025-08-05 Kevin Moore Update dependencies across 3 packages (dart-lang/shelf#479) > > test (https://github.com/dart-lang/test/compare/5aef971..9354f23): > 9354f239 2025-08-07 Liam Appelbe Add `--coverage-path` and `--branch-coverage` options (dart-lang/test#2517) > > tools (https://github.com/dart-lang/tools/compare/5e977d6..1b52e89): > 1b52e89e 2025-08-06 Moritz Configure Gemini code review (dart-lang/tools#2141) > > web (https://github.com/dart-lang/web/compare/1d5771b..f3c960f): > f3c960f 2025-08-06 Nikechukwu [web_generator] Add support for passing files as globs (dart-lang/web#427) > f51cc85 2025-08-06 Nikechukwu [interop] Add Support for Namespaces (dart-lang/web#436) > > webdev (https://github.com/dart-lang/webdev/compare/7ff2d07..94c172c): > 94c172cc 2025-08-05 Nicholas Shahan Wait for any remaining output in e2e_test.dart (dart-lang/webdev#2663) > > Change-Id: Ie18635903f7379bc27e7ae23b916e10e4bdcef94 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444360 > Auto-Submit: Devon Carew <devoncarew@google.com> > Commit-Queue: Konstantin Shcheglov <scheglov@google.com> > Reviewed-by: Konstantin Shcheglov <scheglov@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I239eff7add9e5432c67b05c8f7731e1a79d4e4db Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444387 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>
copybara-service Bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 8, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/414953e..82b48b5): 82b48b53 2025-08-05 István Soós Update highlight.js download instructions and resources. (dart-lang/dartdoc#4081) ecosystem (https://github.com/dart-lang/ecosystem/compare/2fe3618..4543c38): 4543c38 2025-08-06 Devon Carew address a `Bad state: No element` element exception (dart-lang/ecosystem#321) e14472f 2025-08-06 Devon Carew add a roadmap to our various mono-repos (dart-lang/ecosystem#318) e83479a 2025-08-06 Moritz Fixes to health (dart-lang/ecosystem#363) 552f534 2025-08-06 Moritz Update API tool hash (dart-lang/ecosystem#362) i18n (https://github.com/dart-lang/i18n/compare/c45e050..25cdb1b): 25cdb1b4 2025-08-07 Moritz Reenable mac size checks (dart-lang/i18n#1001) shelf (https://github.com/dart-lang/shelf/compare/082d3ac..2a46b4f): 2a46b4f 2025-08-05 Kevin Moore Update dependencies across 3 packages (dart-lang/shelf#479) tools (https://github.com/dart-lang/tools/compare/5e977d6..1b52e89): 1b52e89e 2025-08-06 Moritz Configure Gemini code review (dart-lang/tools#2141) web (https://github.com/dart-lang/web/compare/1d5771b..f3c960f): f3c960f 2025-08-06 Nikechukwu [web_generator] Add support for passing files as globs (dart-lang/web#427) f51cc85 2025-08-06 Nikechukwu [interop] Add Support for Namespaces (dart-lang/web#436) webdev (https://github.com/dart-lang/webdev/compare/7ff2d07..94c172c): 94c172cc 2025-08-05 Nicholas Shahan Wait for any remaining output in e2e_test.dart (dart-lang/webdev#2663) Change-Id: Id553d989bdb5aea483e6ad7d955a965cfaa3cf16 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444362 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.