move analysis_options.yaml into packages#460
Conversation
|
But don't we like having fewer analysis_options files? Is this to work-around an analyzer bug? |
Well, fewer analysis configurations for sure. Most of these are just
I think there is a bug here, because I see different analysis results w/ one top level analysis file vs. the same configs, one in each package. But I like having the packages be self-contained - not depend on files above them in the repo. And this also removes the persistent analysis diagnostic you see if you open the whole repo; the top-level analysis options file can't resolve its reference to package:dart_flutter_team_lints. |
lints (https://github.com/dart-lang/lints/compare/2e1321e..e1d4794): e1d4794 2024-12-03 Michael Goderbauer Revert "Update README.md before archiving (`#214`)" (dart-archive/lints#219) shelf (https://github.com/dart-lang/shelf/compare/657ebd3..2b5b683): 2b5b683 2024-12-02 Devon Carew move analysis_options.yaml into packages (dart-lang/shelf#460) sse (https://github.com/dart-lang/sse/compare/befbd6d..b97dc3a): b97dc3a 2024-12-02 dependabot[bot] Bump dart-lang/setup-dart in the github-actions group (dart-archive/sse#119) test (https://github.com/dart-lang/test/compare/c2a6986..2096773): 20967732 2024-12-03 Devon Carew Update the use of 'package:shelf_web_socket's `webSocketHandler` method (dart-lang/test#2421) 1d28d738 2024-12-02 Ben Konyi Support `package:vm_service` 15.x (dart-lang/test#2420) Change-Id: I852515f46f12b53d2a2fe665a57f7ddcfde36222 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398605 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This catches a number of diagnostics in the shelf packages (mostly instances of
comment_referencesdiagnostics).Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.