Skip to content

add 'unnecessary_library_name' to package:dart_flutter_team_lints#252

Merged
devoncarew merged 5 commits into
mainfrom
add_unnecessary_library_name
May 13, 2024
Merged

add 'unnecessary_library_name' to package:dart_flutter_team_lints#252
devoncarew merged 5 commits into
mainfrom
add_unnecessary_library_name

Conversation

@devoncarew

@devoncarew devoncarew commented Apr 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • add 'unnecessary_library_name' to package:dart_flutter_team_lints
  • require dart 3.4 (not yet published as stable)
  • regen mono_repo content
  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew devoncarew requested a review from natebosch April 29, 2024 18:35
@github-actions github-actions Bot added package:dart_flutter_team_lints type-infra A repository infrastructure change or enhancement labels Apr 29, 2024
@github-actions

github-actions Bot commented Apr 29, 2024 •
edited
Loading

Copy link
Copy Markdown

PR Health

Breaking changes ⚠️

Details
Package Change Current Version New Version Needed Version Looking good?
dart_flutter_team_lints Breaking 3.0.0 3.1.0 4.0.0
Got "3.1.0" expected >= "4.0.0" (breaking changes)		 ⚠️
firehose None 0.9.0 0.9.0 0.9.0 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ❗

Details
Package Changed Files
package:firehose pkgs/firehose/pubspec.yaml

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️

Details
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

Details

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols

License Headers ✔️

Details 
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Details
Package Version Status
package:dart_flutter_team_lints 3.1.0 ready to publish
package:firehose 0.9.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@devoncarew

devoncarew commented Apr 29, 2024

Copy link
Copy Markdown
Contributor Author

From the CI failures, we'd need to bump the min. sdk to 3.4 (not yet published to stable) for unnecessary_library_name to be available.

@devoncarew devoncarew marked this pull request as draft April 29, 2024 19:02
@devoncarew devoncarew mentioned this pull request May 10, 2024
Merged
@devoncarew devoncarew marked this pull request as ready for review May 13, 2024 20:48
@github-actions

github-actions Bot commented May 13, 2024

Copy link
Copy Markdown

Package publishing

Package Version Status Publish tag (post-merge)
package:dart_flutter_team_lints 3.1.0 ready to publish dart_flutter_team_lints-v3.1.0
package:firehose 0.9.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@devoncarew devoncarew merged commit ad9da15 into main May 13, 2024
@devoncarew devoncarew deleted the add_unnecessary_library_name branch May 13, 2024 21:29
copybara-service Bot pushed a commit to dart-lang/sdk that referenced this pull request May 14, 2024
@devoncarew
[deps] rev ecosystem, http, source_map_stack_trace, source_maps, sour…
9b9e8ed 
…ce_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, tools, typed_data, watcher, web, web_socket_channel, webdev, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/5890417..ad9da15):
  ad9da15  2024-05-13  Devon Carew  add 'unnecessary_library_name' to package:dart_flutter_team_lints (dart-lang/ecosystem#252)

http (https://github.com/dart-lang/http/compare/fdb0d36..4722e03):
  4722e03  2024-05-14  Brian Quinlan  Prepare http_profile for publish (dart-lang/http#1197)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/4671c20..6834af5):
  6834af5  2024-05-13  dependabot[bot]  Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-archive/source_map_stack_trace#54)
  f356e62  2024-05-13  Devon Carew  blast_repo fixes (dart-archive/source_map_stack_trace#53)

source_maps (https://github.com/dart-lang/source_maps/compare/c4dc7d0..181a41c):
  181a41c  2024-05-13  dependabot[bot]  Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-archive/source_maps#93)
  a3d7c5c  2024-05-13  Devon Carew  blast_repo fixes (dart-archive/source_maps#92)

source_span (https://github.com/dart-lang/source_span/compare/1695904..e80cb44):
  e80cb44  2024-05-13  dependabot[bot]  Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-archive/source_span#112)
  c2743b4  2024-05-13  Devon Carew  blast_repo fixes (dart-archive/source_span#111)

sse (https://github.com/dart-lang/sse/compare/f5ed4d6..1bb0a98):
  1bb0a98  2024-05-13  dependabot[bot]  Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-archive/sse#110)
  184d72e  2024-05-13  Devon Carew  blast_repo fixes (dart-archive/sse#109)

stack_trace (https://github.com/dart-lang/stack_trace/compare/54c7b9d..4d346f7):
  4d346f7  2024-05-13  dependabot[bot]  Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-archive/stack_trace#154)
  2b053bf  2024-05-13  Devon Carew  blast_repo fixes (dart-archive/stack_trace#153)

stream_channel (https://github.com/dart-lang/stream_channel/compare/ba35137..61ad872):
  61ad872  2024-05-13  dependabot[bot]  Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-archive/stream_channel#106)
  73746a0  2024-05-13  Devon Carew  blast_repo fixes (dart-archive/stream_channel#105)

string_scanner (https://github.com/dart-lang/string_scanner/compare/6e893af..32468bd):
  32468bd  2024-05-13  dependabot[bot]  Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-archive/string_scanner#74)
  395dc7e  2024-05-13  Devon Carew  blast_repo fixes (dart-archive/string_scanner#73)

term_glyph (https://github.com/dart-lang/term_glyph/compare/c3e323b..a46b48b):
  a46b48b  2024-05-13  dependabot[bot]  Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-archive/term_glyph#52)
  cc75160  2024-05-13  Devon Carew  blast_repo fixes (dart-archive/term_glyph#51)

tools (https://github.com/dart-lang/tools/compare/d35d633..86b3661):
  86b3661  2024-05-13  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/tools#270)
  760015a  2024-05-13  Devon Carew  blast_repo fixes (dart-lang/tools#269)

typed_data (https://github.com/dart-lang/typed_data/compare/5b3708e..fb1958c):
  fb1958c  2024-05-13  dependabot[bot]  Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-archive/typed_data#87)
  9c4cb6f  2024-05-13  Devon Carew  blast_repo fixes (dart-archive/typed_data#86)

watcher (https://github.com/dart-lang/watcher/compare/42308ea..c182cd3):
  c182cd3  2024-05-13  dependabot[bot]  Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-archive/watcher#167)
  c7e8d2c  2024-05-13  Devon Carew  blast_repo fixes (dart-archive/watcher#166)

web (https://github.com/dart-lang/web/compare/c36d962..d776645):
  d776645  2024-05-13  dependabot[bot]  Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/web#238)
  a59e8b4  2024-05-13  Devon Carew  blast_repo fixes (dart-lang/web#237)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/5f65bae..8c77d6f):
  8c77d6f  2024-05-13  dependabot[bot]  Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-archive/web_socket_channel#360)
  758148c  2024-05-13  Devon Carew  blast_repo fixes (dart-archive/web_socket_channel#359)

webdev (https://github.com/dart-lang/webdev/compare/9108903..d46cf50):
  d46cf50e  2024-05-13  dependabot[bot]  Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-lang/webdev#2434)
  86a8502e  2024-05-13  Devon Carew  blast_repo fixes (dart-lang/webdev#2433)

yaml (https://github.com/dart-lang/yaml/compare/022ea64..8fb8147):
  8fb8147  2024-05-13  dependabot[bot]  Bump actions/checkout from 4.1.4 to 4.1.5 in the github-actions group (dart-archive/yaml#164)
  620e34b  2024-05-13  Devon Carew  blast_repo fixes (dart-archive/yaml#163)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/c4629ad..3191934):
  3191934  2024-05-13  dependabot[bot]  Bump the github-actions group with 2 updates (dart-archive/yaml_edit#79)
  7dbc61d  2024-05-13  Devon Carew  blast_repo fixes (dart-archive/yaml_edit#78)

Change-Id: I20a413371e3adc9a53e27e1308eac04753a434f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natebosch natebosch natebosch approved these changes

Assignees

No one assigned

Labels

package:blast_repo package:corpus package:dart_flutter_team_lints package:firehose package:repo_manage type-infra A repository infrastructure change or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devoncarew @natebosch