Skip to content

Migrate samples to dot shorthands#3589

Merged
johnpryan merged 2 commits into
dart-lang:mainfrom
loic-sharma:dot_shorthands
Apr 20, 2026
Merged

Migrate samples to dot shorthands#3589
johnpryan merged 2 commits into
dart-lang:mainfrom
loic-sharma:dot_shorthands

Conversation

@loic-sharma

@loic-sharma loic-sharma commented Mar 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of: flutter/flutter#175965

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@loic-sharma loic-sharma mentioned this pull request Mar 21, 2026
Closed
4 tasks
@github-actions

github-actions Bot commented Mar 21, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Health

License Headers ⚠️ 
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
pkgs/samples/lib/brick_breaker.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/dart_services/lib/src/context.dart
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/hello_world.dart

This check can be disabled by tagging the PR with skip-license-check.

Unused Dependencies ✔️
Package Status
None No packages found to check.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

@loic-sharma loic-sharma marked this pull request as ready for review March 23, 2026 18:39
@loic-sharma

loic-sharma commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

It looks like the CI failures will be fixed by this PR: #3591.

Once that lands, I'll rebase this PR.

@johnpryan johnpryan merged commit be6971f into dart-lang:main Apr 20, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnpryan johnpryan johnpryan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loic-sharma @johnpryan