Skip to content

Roll deps#3591

Closed
mit-mit wants to merge 2 commits into
dart-lang:mainfrom
mit-mit:rolldeps
Closed

Roll deps#3591
mit-mit wants to merge 2 commits into
dart-lang:mainfrom
mit-mit:rolldeps

Conversation

@mit-mit

@mit-mit mit-mit commented Mar 23, 2026

Copy link
Copy Markdown
Member

Roll matcher dep to fix tests.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@mit-mit

mit-mit commented Mar 23, 2026

Copy link
Copy Markdown
Member Author

Current test failures:

https://github.com/dart-lang/dart-pad/actions/runs/23392053663/job/68048321104#step:8:124

  Resolving dependencies...
  Note: matcher is pinned to version 0.12.19 by flutter_test from the flutter SDK.
  See https://dart.dev/go/sdk-version-pinning for details.
  
  
  Because dartpad_sample depends on flutter_test from sdk which depends on matcher 0.12.19, matcher 0.12.19 is required.
  So, because dartpad_sample depends on matcher 0.12.18, version solving failed.

@mit-mit mit-mit requested a review from johnpryan March 23, 2026 16:24
@github-actions

github-actions Bot commented Mar 23, 2026

Copy link
Copy Markdown

PR Health

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

Unused Dependencies ✔️
Package Status
None No packages found to check.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

License Headers ✔️ 
""
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/dart_services/bin/server.dart
pkgs/dart_services/lib/server.dart
pkgs/dart_services/lib/src/analysis.dart
pkgs/dart_services/lib/src/caching.dart
pkgs/dart_services/lib/src/common.dart
pkgs/dart_services/lib/src/common_server.dart
pkgs/dart_services/lib/src/compiling.dart
pkgs/dart_services/lib/src/context.dart
pkgs/dart_services/lib/src/experiments.dart
pkgs/dart_services/lib/src/generative_ai.dart
pkgs/dart_services/lib/src/logging.dart
pkgs/dart_services/lib/src/project_creator.dart
pkgs/dart_services/lib/src/project_templates.dart
pkgs/dart_services/lib/src/pub.dart
pkgs/dart_services/lib/src/sdk.dart
pkgs/dart_services/lib/src/shelf_cors.dart
pkgs/dart_services/lib/src/utils.dart
pkgs/dart_services/test/presubmit/analysis_test.dart
pkgs/dart_services/test/presubmit/caching_test.dart
pkgs/dart_services/test/presubmit/compiling_test.dart
pkgs/dart_services/test/presubmit/flutter_web_test.dart
pkgs/dart_services/test/presubmit/genai_test.dart
pkgs/dart_services/test/presubmit/project_creator_test.dart
pkgs/dart_services/test/presubmit/pub_test.dart
pkgs/dart_services/test/presubmit/server_test.dart
pkgs/dart_services/test/presubmit/shelf_cors_test.dart
pkgs/dart_services/test/presubmit/utils_test.dart
pkgs/dart_services/test/probes/server_test.dart
pkgs/dart_services/test/probes_and_presubmit/ddc_testing.dart
pkgs/dart_services/test/probes_and_presubmit/reload_testing.dart
pkgs/dart_services/test/probes_and_presubmit/server_testing.dart
pkgs/dart_services/test/test_infra/utils.dart
pkgs/dart_services/tool/grind.dart
pkgs/dartpad_shared/lib/backend_client.dart
pkgs/dartpad_shared/lib/constants.dart
pkgs/dartpad_shared/lib/headers.dart
pkgs/dartpad_shared/lib/model.dart
pkgs/dartpad_shared/lib/services.dart
pkgs/dartpad_shared/lib/ws.dart
pkgs/dartpad_ui/lib/app/console.dart
pkgs/dartpad_ui/lib/app/docs.dart
pkgs/dartpad_ui/lib/app/editor/editor.dart
pkgs/dartpad_ui/lib/app/editor/generating_panel.dart
pkgs/dartpad_ui/lib/app/editor/stub/editor.dart
pkgs/dartpad_ui/lib/app/editor/web/codemirror.dart
pkgs/dartpad_ui/lib/app/editor/web/editor.dart
pkgs/dartpad_ui/lib/app/editor/web/editor_service.dart
pkgs/dartpad_ui/lib/app/embed/embed.dart
pkgs/dartpad_ui/lib/app/embed/stub.dart
pkgs/dartpad_ui/lib/app/embed/web.dart
pkgs/dartpad_ui/lib/app/execution/execution.dart
pkgs/dartpad_ui/lib/app/execution/view_factory/frame.dart
pkgs/dartpad_ui/lib/app/execution/view_factory/globals.dart
pkgs/dartpad_ui/lib/app/execution/view_factory/stub.dart
pkgs/dartpad_ui/lib/app/execution/view_factory/view_factory.dart
pkgs/dartpad_ui/lib/app/execution/view_factory/web.dart
pkgs/dartpad_ui/lib/app/genai_dialogs.dart
pkgs/dartpad_ui/lib/app/genai_editing.dart
pkgs/dartpad_ui/lib/app/problems.dart
pkgs/dartpad_ui/lib/app/simple_widgets.dart
pkgs/dartpad_ui/lib/app/suggest_fix.dart
pkgs/dartpad_ui/lib/main.dart
pkgs/dartpad_ui/lib/model/keys.dart
pkgs/dartpad_ui/lib/model/model.dart
pkgs/dartpad_ui/lib/primitives/enable_gen_ai.dart
pkgs/dartpad_ui/lib/primitives/enable_websockets.dart
pkgs/dartpad_ui/lib/primitives/extensions.dart
pkgs/dartpad_ui/lib/primitives/flutter_samples.dart
pkgs/dartpad_ui/lib/primitives/gists.dart
pkgs/dartpad_ui/lib/primitives/html_view/html_view.dart
pkgs/dartpad_ui/lib/primitives/html_view/stub.dart
pkgs/dartpad_ui/lib/primitives/html_view/web.dart
pkgs/dartpad_ui/lib/primitives/local_storage/local_storage.dart
pkgs/dartpad_ui/lib/primitives/local_storage/stub.dart
pkgs/dartpad_ui/lib/primitives/local_storage/web.dart
pkgs/dartpad_ui/lib/primitives/theme.dart
pkgs/dartpad_ui/lib/primitives/utils.dart
pkgs/dartpad_ui/lib/primitives/versions.dart
pkgs/dartpad_ui/test/autosave_test.dart
pkgs/dartpad_ui/test/flutter_test_config.dart
pkgs/dartpad_ui/test/gists_test.dart
pkgs/dartpad_ui/test/main_test.dart
pkgs/dartpad_ui/test/model_test.dart
pkgs/dartpad_ui/test/samples_test.dart
pkgs/dartpad_ui/test/test_infra/test_utils.dart
pkgs/samples/lib/brick_breaker.dart
pkgs/samples/lib/default_dart.dart
pkgs/samples/lib/default_flutter.dart
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/hello_world.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart
pkgs/samples/tool/samples.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

johnpryan
johnpryan approved these changes Mar 23, 2026
View reviewed changes

@johnpryan johnpryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mit-mit mit-mit changed the title Roll matcher dep Roll deps Mar 23, 2026
@mit-mit

mit-mit commented Mar 23, 2026

Copy link
Copy Markdown
Member Author

Just rolling matches didn't fix it, so I asked Gemini to run the SKILL and here's the updated PR.

@loic-sharma loic-sharma mentioned this pull request Mar 23, 2026
Merged
1 task
@johnpryan

johnpryan commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Fixed in #3601

@johnpryan johnpryan closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnpryan johnpryan johnpryan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mit-mit @johnpryan