This repository was archived by the owner on Feb 10, 2025. It is now read-only.
Fix dart:convert "UTF8" -> "utf8".#18
Merged
Merged
Conversation
While I was at it, I: - Removed some unused imports. - Fixed a deprecated API call. - Removed the no-longer needed analysis options file.
Contributor
Author
|
This is failing Travis on stable, but that's to be expected. I could remove stable from the Travis config, but I don't want to have to worry about re-adding that later after Dart 2 ships to stable. Is it OK if we just don't worry about that for now? |
Contributor
|
@munificent – just delete the travis config for stable... |
Contributor
Author
Done.
I, uh, already did in the original patch? |
Contributor
I are moron |
kevmoo
approved these changes
Jul 12, 2018
mosuem
pushed a commit
to dart-lang/test
that referenced
this pull request
Dec 12, 2024
…t-2-ready Fix dart:convert "UTF8" -> "utf8".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was at it, I: