Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.

Enable and fix a number of lints, test on oldest supported SDK#15

Merged
kevmoo merged 1 commit into
masterfrom
tweaks
May 6, 2019
Merged

Enable and fix a number of lints, test on oldest supported SDK#15
kevmoo merged 1 commit into
masterfrom
tweaks

Conversation

@kevmoo

@kevmoo kevmoo commented May 5, 2019

Copy link
Copy Markdown
Contributor

Bump min SDK to Dart 2.0

Comment thread test/utils.dart
/// Returns a matcher that asserts that a closure throws a
/// [StringScannerException] with the given [text].
Matcher throwsStringScannerException(String text) =>
throwsA(const TypeMatcher<StringScannerException>()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isA<StringScannerException>? Or does the test with isA require a newer SDK?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have to bump to 2.2 I think...

@kevmoo kevmoo merged commit 705e7bb into master May 6, 2019
@kevmoo kevmoo deleted the tweaks branch May 6, 2019 16:51
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants