Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Close cleanup#4

Merged
grouma merged 13 commits into
masterfrom
close-cleanup
Mar 11, 2019
Merged

Close cleanup#4
grouma merged 13 commits into
masterfrom
close-cleanup

Conversation

@grouma

@grouma grouma commented Mar 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Remove close and onClose from SseConnection
    • This functionality is replaced by the underlying sink / stream
  • Fix an issue where the Sink within the SseConnection wasn't closed
  • Store underlying connections in a map to improve performance
  • Rev package version
  • Make local testing easier

@grouma grouma requested a review from natebosch March 9, 2019 03:03
natebosch
natebosch approved these changes Mar 11, 2019
View reviewed changes
Comment thread lib/server/sse_handler.dart Outdated
Comment thread lib/server/sse_handler.dart Outdated
@grouma grouma merged commit c7d4ecf into master Mar 11, 2019
@grouma grouma deleted the close-cleanup branch March 11, 2019 21:32
@grouma grouma mentioned this pull request Mar 14, 2019
Closed
@aresares aresares mentioned this pull request Apr 25, 2020
Closed
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 10, 2024
@grouma
Merge pull request dart-archive/sse#4 from dart-lang/close-cleanup
6f92177 
Close cleanup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@natebosch natebosch natebosch approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grouma @natebosch