Skip to content
This repository was archived by the owner on Jun 12, 2026. It is now read-only.

Fix codeSyntax to respect encodeHtml flag#239

Merged
srawlins merged 6 commits into
dart-archive:masterfrom
sldsrg:encode-html
Mar 26, 2019
Merged

Fix codeSyntax to respect encodeHtml flag#239
srawlins merged 6 commits into
dart-archive:masterfrom
sldsrg:encode-html

Conversation

@sldsrg

@sldsrg sldsrg commented Mar 25, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@sldsrg

sldsrg commented Mar 25, 2019

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@srawlins srawlins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sldsrg ! Seems like a long-standing obvious bug, but I think encodeHtml: false is not used much (introduced for Flutter, I believe). Your reading of encodeHtml: false is the correct one.

@srawlins srawlins merged commit 0d175aa into dart-archive:master Mar 26, 2019
@sldsrg sldsrg deleted the encode-html branch March 27, 2019 04:45
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants