This repository was archived by the owner on Aug 2, 2025. It is now read-only.
add feedback notes#43
Merged
Merged
Conversation
srawlins
approved these changes
May 21, 2021
devoncarew
reviewed
May 21, 2021
devoncarew
approved these changes
May 21, 2021
devoncarew
left a comment
Contributor
There was a problem hiding this comment.
lgtm!
You could also change the title of the markdown section to help disambiguate things; something like:
## dart-lang/lints or dart-lang/linter ?
Contributor
Author
|
My hesitation w/ "dart-lang/lints or dart-lang/linter" is that I wonder if folks will even know that there's a linter repo and see this and say huh? I don't feel super strongly though. I'll land this and we can iterate. I'd be curious to get @mit-mit's input too. Thanks! |
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 18, 2024
* add feedback notes * typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per our conversation earlier today.
/cc @srawlins @devoncarew @mit-mit