Fix data refresh, variable shadowing, and timer leak in staking dashboard#2390
Draft
Fix data refresh, variable shadowing, and timer leak in staking dashboard#2390
Conversation
* Dashboard network svgs * fixes
* get active validators * validators beacon calls * rm logs * isLoading fix * gweiToToken util * liveness query fix * update comments
* rm logs from validators calls * signer status calls * signer error cards
* db get and set calls * use BeaconchaConsent calls * mock-backend fix * rm useEffect * reorder imports
* dashbaord pkgs links * fix types
…lean up timeout timer Co-authored-by: Marketen <36164126+Marketen@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Refactor and optimize fetching of network statistics
Fix data refresh, variable shadowing, and timer leak in staking dashboard
Feb 24, 2026
Base automatically changed from
mateu/dashboard-fixes
to
mateu/staking-dashboard
February 24, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
useNetworkStatshook migrated from SWR hooks to imperative API calls but lost automatic data revalidation. AlastFetchedNetworksKeyref prevented all re-fetching after initial load, so dashboard data (node status, validators, signers) would go stale permanently.Changes
useNetworkStats— replaces the stale-preventing ref withsetInterval/clearIntervalso node status, validator data, and signer status refresh periodicallylet installedDnpNamesshadowed the React state variable fromuseState; renamed toresolvedInstalledDnpNamesfetchClientWithTimeout—setTimeoutwas never cleared on successful fetch; addedfinallyblock withclearTimeoutuseRefimport✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.