Skip to content

Add support for DAPPNODE_CORE_DIR and disable host scripts feature#2387

Merged
pablomendezroyo merged 7 commits intodevelopfrom
pablo/add-DNCORE_HOST_PATH
Feb 27, 2026
Merged

Add support for DAPPNODE_CORE_DIR and disable host scripts feature#2387
pablomendezroyo merged 7 commits intodevelopfrom
pablo/add-DNCORE_HOST_PATH

Conversation

@pablomendezroyo
Copy link
Copy Markdown
Contributor

@pablomendezroyo pablomendezroyo commented Feb 23, 2026

Context

This update introduces support for a configurable DNCORE_HOST_PATH to specify the location of DNCORE on the host. It also adds a feature to disable host scripts, which is useful for running in development environments like macOS with Docker.

Approach

The solution implements environment variable checks to conditionally execute host integration features, allowing users to disable them when necessary.

Test instructions

  1. Set the DAPPNODE_CORE_DIR environment variable to a custom path and verify that the application uses this path.
  2. Set the DISABLE_HOST_SCRIPTS environment variable to true and ensure that host scripts are not executed during the application startup.
  3. Test the application in both configurations to confirm expected behavior.

@pablomendezroyo pablomendezroyo requested a review from a team as a code owner February 23, 2026 15:13
@github-actions github-actions bot temporarily deployed to commit February 23, 2026 15:14 Inactive
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 23, 2026

@github-actions github-actions bot temporarily deployed to commit February 23, 2026 15:23 Inactive
@github-actions github-actions bot temporarily deployed to commit February 24, 2026 07:04 Inactive
@pablomendezroyo pablomendezroyo changed the title Add support for DNCORE_HOST_PATH and disable host scripts feature Add support for DAPPNODE_CORE_DIR and disable host scripts feature Feb 24, 2026
@github-actions github-actions bot temporarily deployed to commit February 24, 2026 08:07 Inactive
@github-actions github-actions bot temporarily deployed to commit February 25, 2026 08:14 Inactive
@github-actions github-actions bot temporarily deployed to commit February 27, 2026 09:59 Inactive
@pablomendezroyo pablomendezroyo merged commit 1efca22 into develop Feb 27, 2026
8 of 9 checks passed
@pablomendezroyo pablomendezroyo deleted the pablo/add-DNCORE_HOST_PATH branch February 27, 2026 10:04
pablomendezroyo added a commit that referenced this pull request Mar 9, 2026
…2387)

* Add support for DNCORE_HOST_PATH and disable host scripts feature

* Set default value for DISABLE_HOST_SCRIPTS in environment variables

* Add conditional check for DISABLE_HOST_SCRIPTS before starting host reboot daemon

* Update volume path for DAPPNODE_CORE_DIR in docker-compose files

* Enhance ComposeEditor to support allowSubstitution parameter and update related verification logic

* Add DAPPNODE_CORE_DIR support and update restart volumes in params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants