remove backup env in stakers#2340
Merged
pablomendezroyo merged 4 commits intomateu/backup-node-v2from Jan 14, 2026
Merged
Conversation
Marketen
approved these changes
Jan 14, 2026
pablomendezroyo
requested changes
Jan 14, 2026
packages/stakers/src/consensus.ts
Outdated
| } | ||
| >; | ||
| }; | ||
| if (!details.networks) return null; |
Contributor
There was a problem hiding this comment.
this could be simplified to
return details.networks?.[network]?.active === true
? `https://${hash}:@${network}.beacon.dappnode.io`
: null;while still being something readable
packages/stakers/src/consensus.ts
Outdated
|
|
||
| if (!detailsRes.ok) return null; | ||
|
|
||
| const details = (await detailsRes.json()) as { |
Contributor
There was a problem hiding this comment.
instead of type casting, it could be cleaner something like
type NetworkDetails = {
activation_history?: Array<{
activation_date: string;
end_date: string;
}>;
available_activation_seconds?: number;
time_to_be_available?: number;
active?: boolean;
validator_limit?: number;
};
type DetailsResponse = {
id?: string;
networks?: Record<string, NetworkDetails>;
};
const details: DetailsResponse = await detailsRes.json();3b7ae50 to
afaed41
Compare
pablomendezroyo
approved these changes
Jan 14, 2026
pablomendezroyo
pushed a commit
that referenced
this pull request
Jan 14, 2026
* basic layout * sectionNav sm variant * [WIP] layout updated * consensus card * validators card * action cards * info cards improved * Responsiveness info cards * WIP activation history table * sortable table * table improvements * backup node UI adjustments * [WIP] use backup real data * backup UI improvements * Disable backup activation * [WIP] Backup node hooks v2 * formatted activation history * Rename useBackupNode hook * update beacon backup with backend changes * backend changes * fix mock-back * Rename files * ongoing label in history table * Reorganize backup components * backup action cards restyled * backup action cards responsiveness * fix non-premium backup node card * clean imports * backup status error card * rm hardcoded test hashedLicense * rm test urls * BeaconBackupActivationParams new type * fix backupNodeData hook types (#2342) * fix backupNodeData hook types * rename type * remove backup env in stakers (#2340) * remove backup env in stakers * clear backup env of previous CC * clean code * fix backup - stakers types (#2343) --------- Co-authored-by: Marketen <marcfont12@gmail.com> --------- Co-authored-by: Marketen <marcfont12@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove backup env in stakers