Fix panic when encoding undef scalars#66
Merged
dankogai merged 1 commit intodankogai:masterfrom Sep 29, 2016
joyrex2001:master
Merged
Fix panic when encoding undef scalars#66dankogai merged 1 commit intodankogai:masterfrom joyrex2001:master
dankogai merged 1 commit intodankogai:masterfrom
joyrex2001:master
Conversation
Contributor
|
That is not fix! It just hides this bug, which is probably in Encode.xs. If you call ->encode method directly on object then it will still crash. So please drop this patch |
Contributor
|
Real problem is in Encode.xs, Method_encode_xs at line: This does not handle undefined values correctly. |
Contributor
|
Looks like this problem is related to these reported bugs: |
Contributor
|
!!!! Why merging? This patch is totally incorrect! I suggest to immediately revert it and it fix properly! |
Owner
|
The fix may not be perfect but I wanted to merge the test. Also note that the encoder object that |
pali
added a commit
to pali/p5-encode
that referenced
this pull request
Oct 26, 2016
…ment in all XS functions Before this patch every function XS function did it differently and not every one correctly. Now SvPV_force_nomg() is used when source argument is going to be modified. SvGETMAGIC() is called when entering into functions and then only "nomg" variants of perl functions are used to prevent processing get magic more times. SvSETMAGIC() is called after modification of source argument. This fixes bugs: https://rt.cpan.org/Public/Bug/Display.html?id=117158 https://rt.cpan.org/Public/Bug/Display.html?id=85489 dankogai#66
Contributor
|
Proper fix is here: #70 |
rurban
pushed a commit
to rurban/p5-encode
that referenced
this pull request
May 10, 2019
…ment in all XS functions Before this patch every function XS function did it differently and not every one correctly. Now SvPV_force_nomg() is used when source argument is going to be modified. SvGETMAGIC() is called when entering into functions and then only "nomg" variants of perl functions are used to prevent processing get magic more times. SvSETMAGIC() is called after modification of source argument. This fixes bugs: https://rt.cpan.org/Public/Bug/Display.html?id=117158 https://rt.cpan.org/Public/Bug/Display.html?id=85489 dankogai#66
khwilliamson
pushed a commit
to khwilliamson/p5-encode
that referenced
this pull request
May 2, 2020
…ment in all XS functions Before this patch every function XS function did it differently and not every one correctly. Now SvPV_force_nomg() is used when source argument is going to be modified. SvGETMAGIC() is called when entering into functions and then only "nomg" variants of perl functions are used to prevent processing get magic more times. SvSETMAGIC() is called after modification of source argument. This fixes bugs: https://rt.cpan.org/Public/Bug/Display.html?id=117158 https://rt.cpan.org/Public/Bug/Display.html?id=85489 dankogai#66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will fix the "panic: sv_setpvn called with negative strlen at /usr/lib/perl5/5.8.8/i386-linux-thread-multi/Encode/Encoder.pm line 84" error, when you will try to Encoder::encode a undefined scalar. See also the accompanied unit test (t/undef.t).