fix: correctly handle CSS layers#123
Merged
danielroe merged 1 commit intodanielroe:mainfrom Apr 7, 2025
Merged
Conversation
WalkthroughThis pull request expands the CSS rule processing logic in the Changes
Sequence Diagram(s)sequenceDiagram
participant Runner as Processing Engine
participant Beasties
Runner->>Beasties: Invoke processStyle(rule)
alt rule.type is 'atrule'
alt rule.name is 'font-face' or rule.name is 'layer'
Beasties->>Runner: Retain rule for later processing
else
Beasties->>Runner: Skip rule for inline processing
end
else
Beasties->>Runner: Process rule normally
end
Assessment against linked issues
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧬 Code Definitions (1)packages/beasties/test/beasties.test.ts (2)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
CodSpeed Performance ReportMerging #123 will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 85.01% 85.25% +0.23%
==========================================
Files 8 8
Lines 1275 1275
Branches 301 302 +1
==========================================
+ Hits 1084 1087 +3
+ Misses 191 188 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prior to this commit layers where not being handled correctly
1 task
danielroe
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit layers where not being handled correctly
✨
Description by Callstackai
This PR fixes the handling of CSS layers by updating the condition for font-face rules and adding tests for at-rules with layers.
Diagrams of code changes
sequenceDiagram participant Test participant Beasties participant CSSProcessor Test->>Beasties: process(HTML with stylesheet) Note over Beasties: Configure with reduceInlineStyles: false Beasties->>CSSProcessor: Process CSS rules alt @layer rule encountered CSSProcessor-->>CSSProcessor: Preserve @layer rules Note over CSSProcessor: Keep @layer declarations<br/>in first pass end CSSProcessor-->>Beasties: Return processed CSS Beasties-->>Test: Return HTML with<br/>preserved @layer rulesFiles Changed
This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.ts,.snap. See list of supported languages.