Post comment to Bitbucket Server only if there is any content#1331
Merged
Conversation
Member
|
Yeah, this makes sense to me 👍🏻 |
Member
|
Deployed in 8.4.1 |
SalvatoreT
added a commit
to SalvatoreT/danger
that referenced
this pull request
Feb 9, 2023
This feature has already been implemented on Bitbucket Server, but it's missing on Bitbucket Cloud. Bitbucket Server PR: danger#1331 Original issue: danger#1299
SalvatoreT
added a commit
to SalvatoreT/danger
that referenced
this pull request
Feb 9, 2023
This feature has already been implemented on Bitbucket Server, but it's missing on Bitbucket Cloud. Bitbucket Server PR: danger#1331 Original issue: danger#1299
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a simple check to see if a comment should be posted to Bitbucket Server.
The #1299, describes the issue pretty well, but in short, there are some implementation differences between Github and BBS.
Both platforms have the same concepts of comments and build statuses.
On Github there are two actions, comment posting and setting build status.
On BBS the build status update is not fully implemented, but there are methods already so it could be easily finished if needed. Though because BBS requires a build URL, it makes posting one from danger a bit awkward
Now I don't know if there were status badges when the original implementation was done, but now that there is the Code insights implementation, which adds its own status badge to the PR page, sending a separate build status update might be unnecessary.