Upgrade bytelines to latest, without default features#1597
Merged
Conversation
Owner
|
Thanks @whitfin and thanks for bytelines! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! I found this project via an issue opened here: whitfin/bytelines#7 (totally a mistake on my part).
I've finally resolved this temporarily, by adding a feature for Tokio. It's still enabled by default to avoid a breaking change, but this means that you can now disable default features to exclude Tokio + relevant dependencies. Figured I'd file it here so you no longer have to specifically pin a version going forward.
At some point (time permitting) there will be a bytelines v3 which does this more correctly, but for now it'll be one less thing to think about on your end! I'm not sure if you want the
Cargo.lockchanges committed, but I can drop those out as necessary.Thank you!