Skip to content

Make tokio optional#7

Merged
whitfin merged 2 commits into
whitfin:mainfrom
jguhlin:master
Jan 5, 2024
Merged

Make tokio optional#7
whitfin merged 2 commits into
whitfin:mainfrom
jguhlin:master

Conversation

@jguhlin

@jguhlin jguhlin commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Would you be willing to accept this (or similar) PR? I use bytelines pretty extensively but rarely use tokio, and this cuts down on the dependency tree by hiding it behind a "tokio" feature flag.

No worries either way, cheers.

@nickelc

nickelc commented Mar 13, 2023

Copy link
Copy Markdown

This can be further optimized by using only the futures-util crate.

use futures_util::stream::{self, Stream};
[dependencies]
futures-util = { default-features = false }

@whitfin

whitfin commented Dec 30, 2023

Copy link
Copy Markdown
Owner

@jguhlin hi!

So sorry for taking so long to get to this, but happy to merge this in. All looks good, just wanted to double check you're happy with it? Would appreciate if you can add a note to the Tokio part of the README about now needing an option.

Edit: if I don't hear back, I'll circle back soon as get it merged in anyway - I see there's some downstream crates this could be useful for too.

@whitfin whitfin changed the base branch from master to main December 31, 2023 17:46
@whitfin whitfin merged commit 3155521 into whitfin:main Jan 5, 2024
@whitfin

whitfin commented Jan 5, 2024

Copy link
Copy Markdown
Owner

I'm going to merge this and get it released, but tokio will be enabled by default for the moment. I'm going to follow up (hopefully) soon with modules for the other runtimes rather than just Tokio. At this point I'll major bump, and make std the only default feature: #9

Thank you for your help everyone!

@jguhlin

jguhlin commented Jan 7, 2024

Copy link
Copy Markdown
Contributor Author

Apologies, I was out of the office until today and taking a break with bg3. I'm happy with it and thanks for pushing the update out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants