Make tokio optional#7
Conversation
|
This can be further optimized by using only the use futures_util::stream::{self, Stream};[dependencies]
futures-util = { default-features = false } |
|
@jguhlin hi! So sorry for taking so long to get to this, but happy to merge this in. All looks good, just wanted to double check you're happy with it? Would appreciate if you can add a note to the Tokio part of the README about now needing an option. Edit: if I don't hear back, I'll circle back soon as get it merged in anyway - I see there's some downstream crates this could be useful for too. |
|
I'm going to merge this and get it released, but Thank you for your help everyone! |
|
Apologies, I was out of the office until today and taking a break with bg3. I'm happy with it and thanks for pushing the update out! |
Would you be willing to accept this (or similar) PR? I use bytelines pretty extensively but rarely use tokio, and this cuts down on the dependency tree by hiding it behind a "tokio" feature flag.
No worries either way, cheers.