docs: fix grammar in src/ethereum/forks/*/vm/instructions (arithmetic)#2
Merged
Merged
Conversation
- Fix verb form inconsistency in mul() docstring: "Multiply...pushes" changed to "Multiplies...pushes" to match neighboring functions - Fix missing preposition: "instead b'\x00'" -> "instead of b'\x00'"
4 tasks
danceratopz
added a commit
that referenced
this pull request
Mar 11, 2026
…arison (ethereum#2407) * feat: split code for easier testing + add unit test * test(test-execute): add JSONRPCError fallback path test for nonce sync. (#2) - Cover the try/except branch in sync_worker_key_nonce() where get_account with block_number="latest" raises JSONRPCError and the function falls back to "pending". - The existing parametrized tests only exercise the happy path; this completes branch coverage for the extracted function. - Not parametrized because the nonce-sync logic is already proven by the existing cases — this test's concern is the recovery path. --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture