refactor: extract process wiring modules by yohamta0 · Pull Request #2188 · dagucloud/dagu

yohamta0 · 2026-05-21T06:55:03Z

Summary

extract command process wiring into internal/cmd/process modules for server, scheduler, worker, DAG store, coordinator, and agent stores
keep cmd.Context as a thin adapter around role-specific process wiring
move worker static coordinator/shared-nothing client selection behind process wiring

Testing

make lint
make test TEST_TARGET=./internal/cmd/...
go test ./internal/cmd/... -count=1
git diff --check

Summary by CodeRabbit

Refactor
- Consolidated initialization and wiring for server, coordinator, scheduler, worker, and data/store components into a centralized internal module, improving startup consistency and reliability.
- Streamlined optional feature activation (event collection, notifications, incident monitors, license-gated features) for more predictable behavior.
Tests
- Updated tests to exercise and validate the new centralized helpers and runtime wiring.

coderabbitai · 2026-05-21T06:55:53Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 70d300da-6461-4717-a1e0-57549d87de45

📥 Commits

Reviewing files that changed from the base of the PR and between ab5b5f4 and 6a9e342.

📒 Files selected for processing (10)

internal/cmd/context.go
internal/cmd/process/agent_stores.go
internal/cmd/process/coordinator.go
internal/cmd/process/dag_store.go
internal/cmd/process/scheduler.go
internal/cmd/process/server.go
internal/cmd/process/worker.go
internal/cmd/worker.go
internal/cmd/worker_test.go
internal/intg/embed/embed_test.go

📝 Walkthrough

Walkthrough

Refactors internal/cmd to extract server, scheduler, coordinator, DAG store, and agent store construction into internal/cmd/process; context.go and worker wiring now delegate to these new constructors, and tests/embedded integration updated accordingly.

Changes

Component wiring consolidation

Layer / File(s)	Summary
Process package foundations: stores and coordinator `internal/cmd/process/dag_store.go`, `internal/cmd/process/agent_stores.go`, `internal/cmd/process/coordinator.go`	`DAGStoreConfig` and `NewDAGStore` construct file-backed DAG storage; `AgentStores` and `NewAgentStores` bundle agent-related stores with optional OAuth and context resolution; `NewCoordinatorClient` builds coordinator clients with TLS validation.
Server process construction `internal/cmd/process/server.go`	`ServerConfig` and `NewServer` orchestrate frontend server initialization: cache/store creation, DAG definition caching, telemetry collection, coordinator wiring, and optional license/heartbeat/lease store API options.
Scheduler process construction `internal/cmd/process/scheduler.go`	`SchedulerConfig` and `NewScheduler` construct the scheduler with caching, stores, and event services; `newNotificationMonitor` and `newIncidentMonitor` wire encrypted notification/incident system integration.
Worker coordinator client construction `internal/cmd/process/worker.go`	`BuildWorkerCoordinatorClientConfig` and `NewWorkerCoordinatorClient` encapsulate worker-specific coordinator setup supporting static or service-discovery modes with `useRemoteHandler` flag.
Context refactoring to delegate to cmdprocess `internal/cmd/context.go`	`NewServer`, `NewCoordinatorClient`, `NewScheduler`, `dagStore`, and `agentStores` methods replace in-file wiring with thin wrappers delegating to `cmdprocess` constructors; imports updated.
Worker and test updates `internal/cmd/worker.go`, `internal/cmd/worker_test.go`	`createCoordinatorClient` delegates to `cmdprocess.NewWorkerCoordinatorClient`; tests updated to call `cmdprocess.BuildWorkerCoordinatorClientConfig`.
Embedded test binary resolution `internal/intg/embed/embed_test.go`	Adds helper to resolve binary paths via `exec.LookPath` and updates embedded YAML steps to reference resolved `whoami` binary.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

dagucloud/dagu#2081: Refactors scheduler and GitHub dispatch worker initialization overlapping scheduler/GitHub-dispatch wiring.
dagucloud/dagu#2041: Adds worker heartbeat store wiring into frontend API options; related to frontend/server API option consolidation.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 68.75% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: extracting process wiring modules from the command context.
Description check	✅ Passed	The description covers the main objectives (extraction of process wiring modules and keeping cmd.Context as adapter) and lists comprehensive testing commands, but omits the standard PR template sections for individual change list and related issues.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch refactor/process-wiring-modules

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@internal/cmd/process/worker.go`:
- Around line 24-35: The static coordinator config created with
coordinator.DefaultConfig() populates TLS/insecure fields but omits the peer
retry settings; update coordCliCfg before calling coordCliCfg.Validate() to copy
cfg.Core.Peer.MaxRetries and cfg.Core.Peer.RetryInterval into coordCliCfg (e.g.,
set coordCliCfg.MaxRetries = cfg.Core.Peer.MaxRetries and
coordCliCfg.RetryInterval = cfg.Core.Peer.RetryInterval) so the static worker
path respects the configured retry behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e946be19-183f-4be9-b4fd-b76ef1395083

📥 Commits

Reviewing files that changed from the base of the PR and between f361a1f and 8988c1a.

📒 Files selected for processing (9)

internal/cmd/context.go
internal/cmd/process/agent_stores.go
internal/cmd/process/coordinator.go
internal/cmd/process/dag_store.go
internal/cmd/process/scheduler.go
internal/cmd/process/server.go
internal/cmd/process/worker.go
internal/cmd/worker.go
internal/cmd/worker_test.go

yohamta0 · 2026-05-21T07:05:00Z

@coderabbitai review

coderabbitai · 2026-05-21T07:05:06Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

yohamta0 · 2026-05-21T09:06:38Z

@coderabbitai review

coderabbitai · 2026-05-21T09:06:44Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai Bot reviewed May 21, 2026

View reviewed changes

Comment thread internal/cmd/process/worker.go

yohamta0 force-pushed the main branch from f361a1f to 0124650 Compare May 21, 2026 08:05

yohamta0 force-pushed the refactor/process-wiring-modules branch from 29ef533 to 3d2c3f8 Compare May 21, 2026 08:18

yohamta0 force-pushed the main branch from 0124650 to f2b7cae Compare May 21, 2026 08:24

yohamta0 added 4 commits May 21, 2026 17:41

refactor: extract process wiring modules

7dd2c0a

fix: preserve worker coordinator retry settings

cbe4069

docs: clarify scheduler monitor wiring

cd3d1f5

test: harden embedded run yaml on windows

6a9e342

yohamta0 force-pushed the refactor/process-wiring-modules branch from 3d2c3f8 to 6a9e342 Compare May 21, 2026 08:43

yohamta0 merged commit 1e40d7e into main May 21, 2026
10 checks passed

yohamta0 deleted the refactor/process-wiring-modules branch May 21, 2026 10:51

yohamta0 added a commit that referenced this pull request May 21, 2026

refactor: extract process wiring modules (#2188)

e36e199

coderabbitai Bot mentioned this pull request Jun 10, 2026

feat: RPC fallback for missing DAG definitions on workers #2271

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: extract process wiring modules#2188

refactor: extract process wiring modules#2188
yohamta0 merged 4 commits into
mainfrom
refactor/process-wiring-modules

yohamta0 commented May 21, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 21, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

yohamta0 commented May 21, 2026

Uh oh!

coderabbitai Bot commented May 21, 2026

Uh oh!

yohamta0 commented May 21, 2026

Uh oh!

coderabbitai Bot commented May 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

yohamta0 commented May 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yohamta0 commented May 21, 2026

Uh oh!

coderabbitai Bot commented May 21, 2026

Uh oh!

yohamta0 commented May 21, 2026

Uh oh!

coderabbitai Bot commented May 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

yohamta0 commented May 21, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 21, 2026 •

edited

Loading