fix: Fix crash when a simple forall statement was placed inside a match#6121
Merged
Conversation
MikaelMayer
approved these changes
Feb 24, 2025
fabiomadge
added a commit
that referenced
this pull request
Jun 30, 2025
Addresses issue #6268 by identifying and partially fixing the root cause. ROOT CAUSE DISCOVERED: Cloning Issue (similar to #6121) - In match cases, HideRevealStmt objects are cloned during desugaring - Cloning creates new AssertLabel objects without preserving E field - Original AssertLabel objects get E field filled during Boogie generation - Cloned AssertLabel objects accessed by reveal statements have null E field - Contract.Assert(la.E != null) crashes when accessing cloned objects THE FIX: Graceful Null Handling - Skip processing AssertLabel objects with null E field - Prevents crash but doesn't restore full functionality - Reveal statements in match cases don't work but don't crash LIMITATION: Functionality Not Fully Restored - This prevents the crash but reveal statements don't work in match cases - Full fix would require connecting cloned objects to original translated expressions - Similar pattern to ForallStmt fix in #6121 but more complex due to E field timing This demonstrates the cloning issue pattern and provides crash prevention while acknowledging the need for a more complete architectural solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6120
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.