General: Trim Play Store screenshots to smoke locales#585
Merged
Conversation
Mirrors permission-pilot's policy: only the 6 smoke locales (en-US, de-DE, ja-JP, ar, zh-CN, pt-BR) check phoneScreenshots PNGs into the repo. Non-smoke locales are excluded via .gitignore. Drops fastlane/metadata/android/ from ~67 MB to ~7 MB and prevents future bloat from full regens. Play Store's supply retains previously-uploaded screenshots for locales not pushed, so full localization is maintained by occasional manual regen + screenshots_only upload.
d4rken
added a commit
to d4rken-org/permission-pilot
that referenced
this pull request
May 4, 2026
Mirror the d4rken-org/capod#585 pattern: gitignore Play Store phone screenshots for non-smoke locales, keeping only the 6 smoke locales (en-US, de-DE, ja-JP, ar, zh-CN, pt-BR) tracked. The smoke set matches SMOKE_LOCALES in fastlane/generate_screenshots.sh. Future screenshot refreshes only diff 6 locales x 6 screens = 36 PNGs instead of 234, so reviews stay readable. Full localization is generated + uploaded on demand via 'bundle exec fastlane screenshots_only'; Fastlane skips locales with no local files, so absent locales keep whatever Play Store currently has. Also: fail generate_screenshots.sh non-zero on PNG count mismatch (was a soft warning), fix the stale '39 x 7 screens' comment in build-commands.md (it's 39 x 6), and add .claude/rules/screenshots.md describing the regen + upload + working-tree cleanup workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
No user-facing behavior change. Trims the committed Play Store phone screenshots from 68 locales to 6 (en-US, de-DE, ja-JP, ar, zh-CN, pt-BR) to slim the repo. The Play Store listing stays fully localized:
fastlane supplyretains previously-uploaded screenshots for any locale not present in the upload, so non-smoke locales keep whatever is currently live until someone runs an occasional manual full regen + upload.Also bumps a few transitive Ruby gem versions in
fastlane/Gemfile.lock(addressable, aws-*, etc.) — picked up from a localbundle install.Technical Context
supplydoesn't wipe locales it isn't given.gitignorerule excludesfastlane/metadata/android/*/images/phoneScreenshots/*.pngwith!exceptions for the 6 smoke locales — prevents accidental re-add when a developer runs full mode locallyfastlane/metadata/android/from ~67 MB to ~7 MB on disk; the 67 MB from PR General: Refresh Play Store screenshots #584 still lives in git history, this PR only stops further growth.claude/rules/screenshots.md: smoke is now the documented default; full regen is called out as a periodic manual operation paired withbundle exec fastlane screenshots_only