General: Clean up release-prepare step name and use client-id for App auth#569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Two small follow-ups from the App-token rollout:
app-id→client-idonactions/create-github-app-token.app-idis deprecated upstream (warning printed on every run);client-idis the supported input now.Action required before merging
The
client-idswap requires a new org secret. Steps:Iv1.<hex>or similar)RELEASE_APP_CLIENT_IDwith that value, scoped the same way asRELEASE_APP_ID(selected repos:capod, or all)RELEASE_APP_IDsecret can be deletedTechnical Context
client-idandapp-ididentify the same App but in different formats. The action accepts either; onlyclient-idis non-deprecated.