Skip to content

General: Restore two-step release approval flow#565

Merged
d4rken merged 1 commit into
mainfrom
chore/release-prepare-no-env-gate
May 1, 2026
Merged

General: Restore two-step release approval flow#565
d4rken merged 1 commit into
mainfrom
chore/release-prepare-no-env-gate

Conversation

@d4rken

@d4rken d4rken commented May 1, 2026

Copy link
Copy Markdown
Member

What changed

No user-facing behavior change. Drops the foss-production environment gate from release-prepare.yml's push-and-dispatch job so the bump/tag/push fires immediately after compute-and-validate completes. The downstream release-tag.yml jobs still gate on foss-production (release-github) and gplay-production (release-gplay) — those remain the two human checkpoints, matching the pre-migration approval flow.

Technical Context

  • The prepare-side gate added a third approval click on top of the existing two, with no real safety net beyond what Job 1's summary already shows. If the planned version looks wrong, cancel the run between Job 1 and Job 2 (the window is short but the summary is on screen by the time Job 2 starts).
  • The atomicity guarantees inside Job 2 (atomic push, validate-tag in release-tag.yml) didn't depend on the env gate — they still hold.
  • validate-tag in release-tag.yml continues to defend against hand-pushed v* tags or manual gh workflow run release-tag.yml invocations.

@d4rken d4rken merged commit 2240bd7 into main May 1, 2026
11 checks passed
@d4rken d4rken deleted the chore/release-prepare-no-env-gate branch May 1, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant