Merged
Conversation
ignored rather than used). This affects the Limited API, sharedlib, different GCC versions and a few others. I can't see an easy way of passing env in, so I've replaced it with a whole bunch of optional parameters.
Contributor
Author
|
This is expected to fail because of a Limited API issue which I'll fix separately - I actual want to see it fail though to know it's working. |
da-woods
added a commit
to da-woods/cython
that referenced
this pull request
Mar 16, 2026
Broken in the Limited API in eee7a60 but undetected because of cython#7574
da-woods
added a commit
that referenced
this pull request
Mar 18, 2026
Contributor
|
Your PR description looks incomplete. Apart from that, I'm fine with the change. It's as explicit as it gets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
envargument is ignored rather than used. This affects the Limited API, sharedlib, different GCC versions and a few others.I can't see an easy way of passing env in, so I've replaced it with a whole bunch of optional parameters.