Skip to content

pin setuptools<60#4510

Merged
scoder merged 1 commit intocython:masterfrom
mattip:pin-setuptools
Dec 21, 2021
Merged

pin setuptools<60#4510
scoder merged 1 commit intocython:masterfrom
mattip:pin-setuptools

Conversation

@mattip
Copy link
Copy Markdown
Contributor

@mattip mattip commented Dec 21, 2021

Try to unbreak CI?

It seems around the time CI stopped passing, setuptools changed from 59.7.0 to 60.0.0, see this comment for more info

@scoder
Copy link
Copy Markdown
Contributor

scoder commented Dec 21, 2021

Related setuptools change: pypa/setuptools#2896

@scoder
Copy link
Copy Markdown
Contributor

scoder commented Dec 21, 2021

Seems to resolve the issue. The recommended way is to set SETUPTOOLS_USE_DISTUTILS=local, apparently. Although I wonder what the gain of the change in setuptools is if everyone starts doing that…

@mattip
Copy link
Copy Markdown
Contributor Author

mattip commented Dec 21, 2021

NumPy and Scipy are looking to move to meson or cmake xref scipy/scipy#13615

scoder added a commit that referenced this pull request Dec 21, 2021
@scoder
Copy link
Copy Markdown
Contributor

scoder commented Dec 21, 2021

NumPy and Scipy are looking to move to meson or cmake xref scipy/scipy#13615

Let's try to get Cython 3.0 released at some point, before I look into yet another build system / CI setup / wheel builder / toolchain replacement or breakage. Honestly, I've had enough of those recently.

@mattip
Copy link
Copy Markdown
Contributor Author

mattip commented Dec 21, 2021

Sure, that makes sense, and I would not expect Cython to be the first to make the jump.

@scoder
Copy link
Copy Markdown
Contributor

scoder commented Dec 21, 2021

Ok, your PR wins then. :-)

@scoder scoder added this to the 3.0 milestone Dec 21, 2021
@scoder scoder added the Testing label Dec 21, 2021
@scoder scoder merged commit 14ec0d1 into cython:master Dec 21, 2021
@mattip
Copy link
Copy Markdown
Contributor Author

mattip commented Dec 21, 2021

I will try to reproduce locally, if I can I will open an issue with setuptools.

@scoder
Copy link
Copy Markdown
Contributor

scoder commented Dec 21, 2021

Thanks @mattip !

@mattip
Copy link
Copy Markdown
Contributor Author

mattip commented Dec 21, 2021

Ahh, it may be a Cython thing. The ci-run.sh script is setting CC and CXX, maybe now setuptools is respecting that and not adding -pthread

cython/Tools/ci-run.sh

Lines 25 to 28 in 14ec0d1

export CC="gcc"
if [[ $BACKEND == *"cpp"* ]]; then
sudo update-alternatives --set g++ /usr/bin/g++-$GCC_VERSION
export CXX="g++"

@scoder
Copy link
Copy Markdown
Contributor

scoder commented Dec 21, 2021

Ahh, it may be a Cython thing. The ci-run.sh script is setting CC and CXX, maybe now setuptools is respecting that and not adding -pthread

cython/Tools/ci-run.sh

Lines 25 to 28 in 14ec0d1

export CC="gcc"
if [[ $BACKEND == *"cpp"* ]]; then
sudo update-alternatives --set g++ /usr/bin/g++-$GCC_VERSION
export CXX="g++"

I was always wondering why CC would be set to gcc -pthreads rather than leaving that to the application that uses it. Looks like we did similar stuff in the test setup ourselves. Oh well…

@eli-schwartz
Copy link
Copy Markdown
Contributor

NumPy and Scipy are looking to move to meson or cmake xref scipy/scipy#13615

The proper experience for that would be greatly helped by cython learning to emit buildsystem-independent depfiles as per #1214 #1459

All the more so if cython itself wants to consider at some point switching off of setuptools :D as then it would be needed internally too.

@scoder
Copy link
Copy Markdown
Contributor

scoder commented Dec 22, 2021

The proper experience for that would be greatly helped by cython learning to emit buildsystem-independent depfiles as per #1214

Help with that is welcome. There was already an initial (rough) PR (#243) at some point, but I think that's only worth inspiration but not pursuing any more. cythonize collects all direct dependencies anyway in order to determine if it needs to translate a file, so writing them to disk after the fact shouldn't be difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants