Use platform dependent test for unpacked_struct_with_arrays#3621
Merged
scoder merged 1 commit intocython:masterfrom May 20, 2020
Merged
Use platform dependent test for unpacked_struct_with_arrays#3621scoder merged 1 commit intocython:masterfrom
scoder merged 1 commit intocython:masterfrom
Conversation
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
May 20, 2020
use patch from upstream: cython/cython#3621
Contributor
|
Thanks! |
scoder
pushed a commit
that referenced
this pull request
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to address #3620.
I'm not sure about the recommended way to make the tests conditional on the platform, however, hopefully this is ok. I'm very happy to readdress the the issue using a different method though if that is preferred.
Please note that I also do not have access to a 32bit OS to test this on (I attempted to use an i386 Alpine linux docker image but was unable to get things running).
I'll also add further discussion to #3620...