feat: always provide ci-build-id so actions can be re-run#340
feat: always provide ci-build-id so actions can be re-run#340bahmutov merged 1 commit intocypress-io:send-ci-build-idfrom
Conversation
|
I would like it if I did not have to continuously answer this question for people. They don't see the warning about it in the github actions readme. |
|
So... you are on board with the idea? 😅 not entirely sure if i got the intention right |
|
@bahmutov thoughts? |
|
I am not sure I understand what this PR changes. There is refactoring, but ultimately we still use the same ciBuildId, no? How would it change anything the user has to do? |
|
@bahmutov this |
|
@Andarist do you have a situation that without this PR it does NOT create a new test run? I am trying this right now in https://github.com/bahmutov/cypress-gh-action-small-example and it creates new dashboard runs on every re-run just fine, no? |
|
I'm using this in a private repo - I could try to set up a public repro later if you will require that. I've tracked down my workflow runs from before I've fixed this on our side and I got: Which was a result of re-running the workflow manually from the GitHub interface. I've resolved this on our side by generating a - command: yarn ci:test:integration:cypress
+ command: yarn ci:test:integration:cypress -- --ci-build-id ${{ steps.date.outputs.date }}which has fixed the issue. |
bahmutov
left a comment
There was a problem hiding this comment.
Looks good, let me merge it into our branch to fully test it
closes #363
I know that there are known workarounds for this, mentioned both in the README and some issue comments.
Since this is relevant not only for parallel runs I think that adding this at all times would improve the DX and provide this improvement out of the box for all users. The expected result is that a GitHub action should be able to re-run the workflow and create a new test run in the Cypress dashboard.