Move dragHold into dispatch#3109
Merged
raineorshine merged 1 commit intocybersemics:mainfrom Jul 4, 2025
Merged
Conversation
This was referenced Jul 2, 2025
raineorshine
approved these changes
Jul 4, 2025
Contributor
raineorshine
left a comment
There was a problem hiding this comment.
Seems reasonable. Thanks!
cindmichelle
pushed a commit
to cindmichelle/em
that referenced
this pull request
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #3080
This is about as much as I was able to accomplish re: #3081 (comment)
dragInProgressviauseSelector, then we shouldn't need to do it fordragHoldeitheruseEffecte.preventDefault()to the existingdragInProgresscondition, which may be unnecessary but I don't think is harmful(!globals.touching && (!editingOrOnCursor || !isVisible))dragHoldwas being checked in order to fix this bug: #3023 (comment) and I verified that that bug is still fixed after moving it.