Fix for 2 dimensional dependent bounded quantifiers#6710
Merged
ajreynol merged 3 commits intocvc5:masterfrom Jun 8, 2021
Merged
Fix for 2 dimensional dependent bounded quantifiers#6710ajreynol merged 3 commits intocvc5:masterfrom
ajreynol merged 3 commits intocvc5:masterfrom
Conversation
4tXJ7f
approved these changes
Jun 8, 2021
Member
4tXJ7f
left a comment
There was a problem hiding this comment.
LGTM, glad we figured that one out :)
4tXJ7f
pushed a commit
to 4tXJ7f/cvc5
that referenced
this pull request
Jun 11, 2021
This updates 2-dim dependent bounded quantifiers to not map constants to terms when computing ranges, when the type of the variable is closed enumerable. This is require to fix an incorrect model (possible solution unsoundness) issue in the reduction of str.indexof_re. Fixes the 1st, 4th and 5th benchmarks from cvc5#6653. Fixes cvc5#6635.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates 2-dim dependent bounded quantifiers to not map constants to terms when computing ranges, when the type of the variable is closed enumerable. This is require to fix an incorrect model (possible solution unsoundness) issue in the reduction of
str.indexof_re.Fixes the 1st, 4th and 5th benchmarks from #6653. Fixes #6635.