Skip to content

curl: make --remote-time error message respect --silent#6535

Closed
bagder wants to merge 3 commits intomasterfrom
bagder/fprintf2warnf
Closed

curl: make --remote-time error message respect --silent#6535
bagder wants to merge 3 commits intomasterfrom
bagder/fprintf2warnf

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Jan 26, 2021

... and provide a little more details in the error messages.

Fixes #6533

bagder added 3 commits January 26, 2021 17:03
@bagder
curl: move fprintf outputs to warnf
6b6a7a5 
For setting and getting time of the download. To make the outputs
respect --silent etc.

Reported-by: Viktor Szakats
Fixes #6533
@bagder
curl: s/config->global/global/ in single_transfer()
6717ca0
@bagder
curl: include the file name in --xattr/--remote-time error msgs
4fcba29
@jay
Copy link
Copy Markdown
Member

jay commented Jan 26, 2021

Is there any harm in removing global parameters entirely, they're always pointing to actual global struct afaics.

@bagder
Copy link
Copy Markdown
Member Author

bagder commented Jan 26, 2021 •
edited
Loading

The struct is not actually global right now, it is declared first thing within main() here:

curl/src/tool_main.c

Line 242 in d3ca077

struct GlobalConfig global;

It could of course probably be converted into a global with little side-effects. But that would then make it much harder to introduce multiple such structs if we ever want to do that - not that I can think of why we would want it...

I'll save that for another day! 😁

@bagder bagder closed this in 71acece Jan 27, 2021
@bagder bagder deleted the bagder/fprintf2warnf branch January 27, 2021 07:46
mback2k added a commit to mback2k/curl that referenced this pull request Nov 1, 2021
@mback2k
Revert "src/tool_filetime: disable -Wformat on mingw for this file"
a0d0ab6 
This reverts commit 7c88fe3.

Follow up to curl#6535 as the pragma is obsolete with warnf
This was referenced Nov 1, 2021
Closed
Closed
bagder pushed a commit that referenced this pull request Nov 3, 2021
@mback2k @bagder
Revert "src/tool_filetime: disable -Wformat on mingw for this file"
45a7821 
This reverts commit 7c88fe3.

Follow up to #6535 as the pragma is obsolete with warnf

Closes #7941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cmdline tool

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unuseful warnings with --xattr/--remote-time + --output /dev/null

2 participants

@bagder @jay