tool_doswin: avoid Windowsisms in socket code#20452
Closed
vszakats wants to merge 2 commits intocurl:masterfrom
Closed
tool_doswin: avoid Windowsisms in socket code#20452vszakats wants to merge 2 commits intocurl:masterfrom
vszakats wants to merge 2 commits intocurl:masterfrom
Conversation
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jan 27, 2026
Follow-up to a81ab3e curl#20452 Follow-up to 9a26633 curl#17572
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jan 28, 2026
Follow-up to a81ab3e curl#20452 Follow-up to 9a26633 curl#17572
vszakats
added a commit
that referenced
this pull request
Jan 28, 2026
For general readability. Also to match the rest of the source code. - bump `send()` result type from `int` to `ssize_t`. - fix an `int` to be `curl_socklen_t`. - `.S_un.S_addr` -> `.s_addr`. - `SD_RECEIVE` -> `SHUT_RD`. - `SD_SEND` -> `SHUT_WR`. Follow-up to a81ab3e #20452 Follow-up to 9a26633 #17572 Closes #20457
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For general readability. Also to match the rest of the source code.
SOCKADDR→struct sockaddrSOCKADDR_IN→struct sockaddr_in== SOCKET_ERROR→== -1or silent!= 0Follow-up to 9a26633 #17572