Skip to content

GHA/codeql: enable cares, debug, build curlinfo, examples#18564

Closed
vszakats wants to merge 2 commits intocurl:masterfrom
vszakats:cqlcares
Closed

GHA/codeql: enable cares, debug, build curlinfo, examples#18564
vszakats wants to merge 2 commits intocurl:masterfrom
vszakats:cqlcares

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Sep 16, 2025

Also build examples, out of curiousity, as an experiment, possibly
temporary. It needs around 40 seconds.

@vszakats vszakats added tests CI Continuous Integration labels Sep 16, 2025
@vszakats vszakats changed the title GHA/codeql: enable cares, debug, build curlinfo GHA/codeql: enable cares, debug, build curlinfo, examples Sep 16, 2025
@vszakats vszakats closed this in b4922b1 Sep 18, 2025
@vszakats vszakats deleted the cqlcares branch September 18, 2025 14:48
vszakats added a commit that referenced this pull request Sep 18, 2025
- http2-upload: use `fstat()` to query file length to fix TOCTOU.

- ftpuploadresume: fix checking `sscanf()` return value.

Follow-up to b4922b1 #18564
Closes #18605
vszakats added a commit that referenced this pull request Sep 18, 2025
vszakats added a commit that referenced this pull request Nov 21, 2025
Turns out the cause of CodeQL hangs (or probably just extreme long
compile) is the header `curl/typecheck-gcc.h`. By accident I noticed
that the preprocessed output of libtests.c is 75 MB (megabytes). This
is much higher than the amounf of source code hinted, also compared to
e.g. units.c or other build targets. The reason for the extreme size
is each easy option call pulling in the large checker logic defined
in this header.

By compiling with `-DCURL_DISABLE_TYPECHECK`, preprocessed output drops
to 2.2 MB (34x), and the libtests target builds without issues.

Also build all tests and examples with the Linux HTTP/3 config, covering
3 more files.

With these, CodeQL C coverage is 893 out of 930 (96%) (was: 645 69%)

Follow-up to 71fc11e #18695
Follow-up to a333fd4 #18557
Follow-up to b4922b1 #18564

Closes vszakats#11
Closes #19632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration tests

Development

Successfully merging this pull request may close these issues.

1 participant