Closed
Conversation
Disable pthread_cancel in pushed cleanup function. Close wakeup socket when shutting down resolving, since we no longer want wakeups.
vszakats
reviewed
Aug 21, 2025
vszakats
approved these changes
Aug 21, 2025
Member
vszakats
left a comment
There was a problem hiding this comment.
LGTM, it's kind of magic, so I say let's merge, and CI will tell
if there is any remaining flakiness there.
bagder
approved these changes
Aug 21, 2025
Member
|
Unfortunately, this broke the |
Contributor
Author
Thanks. Should be addressed via #18347 |
vszakats
added a commit
that referenced
this pull request
Aug 22, 2025
A wrong type here has seen to manifest in CI failures with gcc-12 macOS. Ref: #18348 (comment) Ref: https://github.com/curl/curl/actions/runs/17153761944/job/48665734013?pr=18349 Follow-up to b63cce7 #18339 Follow-up to 88fc6c4 #18263 Closes #18355
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable pthread_cancel in pushed cleanup function. Close wakeup socket when shutting down resolving, since we no longer want wakeups.