Closed
Conversation
Member
Author
|
shellcheck sure has opinions, and seems to have been updated |
fb14853 to
2a8335c
Compare
Member
Author
|
Complications to overcome include: hostsProbably due to local config in the GitHub CI runners all resolves are also done with extra domains added, like: I need to add filtering in the test logic that checks the request DNS request orderingc-ares and the threaded-resolver send their outgoing DNS requests in a different order. I make the check on sorted packet logs. HTTPS request amountFor some reason I don't quite know, the c-ares backend makes three HTTPS requests and the threaded only does one, which makes the test case complicated. |
Hold them for half the normal lifetime. Helps when told to transfer N URLs in quick succession that all use the same non-resolving hostname. Done by storing a DNS entry with a NULL pointer for 'addr'. Previously an attempt was made in #12406 by Björn Stenberg that was ultimately never merged. Closes #18157
503cd33 to
cf25056
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jan 15, 2026
Follow-up to df2b4cc curl#18157 Follow-up to 02e9690 curl#17015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hold them for half the normal lifetime. Helps when told to transfer N URLs in quick succession that all use the same non-resolving hostname.
Done by storing a DNS entry with a NULL pointer for 'addr'.
Previously an attempt was made in #12406 by Björn Stenberg (@zagor) that was ultimately never merged.
TODO